You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/21 11:31:01 UTC
[GitHub] [hudi] cuibo01 opened a new pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
cuibo01 opened a new pull request #4862:
URL: https://github.com/apache/hudi/pull/4862
ParquetColumnarRowSplitReader#batchSize is 2048, so Changing MINI_BATCH_SIZE to 2048 will reduce memory cache.
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046785974
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on a change in pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on a change in pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#discussion_r815533927
##########
File path: hudi-flink/src/main/java/org/apache/hudi/source/StreamReadOperator.java
##########
@@ -64,7 +64,7 @@
private static final Logger LOG = LoggerFactory.getLogger(StreamReadOperator.class);
- private static final int MINI_BATCH_SIZE = 1000;
+ private static final int MINI_BATCH_SIZE = 2048;
Review comment:
@danny0405 from memory dump：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1047369505
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169",
"triggerID" : "1046861163",
"triggerType" : "MANUAL"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6184",
"triggerID" : "1047334466",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6184)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046854817
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#discussion_r811858212
##########
File path: hudi-flink/src/main/java/org/apache/hudi/source/StreamReadOperator.java
##########
@@ -64,7 +64,7 @@
private static final Logger LOG = LoggerFactory.getLogger(StreamReadOperator.class);
- private static final int MINI_BATCH_SIZE = 1000;
+ private static final int MINI_BATCH_SIZE = 2048;
Review comment:
I see your comment:
> ParquetColumnarRowSplitReader#batchSize is 2048, so Changing MINI_BATCH_SIZE to 2048 will reduce memory cache
Thanks, do we have some metrics to illustrate the benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046782988
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1047618940
@danny0405 pls review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1047334466
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046919380
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169",
"triggerID" : "1046861163",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046861163
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046862114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169",
"triggerID" : "1046861163",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046919380
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169",
"triggerID" : "1046861163",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on a change in pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on a change in pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#discussion_r811872585
##########
File path: hudi-flink/src/main/java/org/apache/hudi/source/StreamReadOperator.java
##########
@@ -64,7 +64,7 @@
private static final Logger LOG = LoggerFactory.getLogger(StreamReadOperator.class);
- private static final int MINI_BATCH_SIZE = 1000;
+ private static final int MINI_BATCH_SIZE = 2048;
Review comment:
In our production environment, flink hudi jobs require a lot of memory, and I'm checking memory usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1047334883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169",
"triggerID" : "1046861163",
"triggerType" : "MANUAL"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6184",
"triggerID" : "1047334466",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6184)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046782988
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1047334883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169",
"triggerID" : "1046861163",
"triggerType" : "MANUAL"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6184",
"triggerID" : "1047334466",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6184)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #4862:
URL: https://github.com/apache/hudi/pull/4862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046785974
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046854817
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#issuecomment-1046862114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164",
"triggerID" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"triggerType" : "PUSH"
}, {
"hash" : "98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169",
"triggerID" : "1046861163",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98b0b2816f33c4a2f5576e3581a11d1b9dd1ee26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6164) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6169)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on a change in pull request #4862: [MINOR] Change MINI_BATCH_SIZE to 2048
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on a change in pull request #4862:
URL: https://github.com/apache/hudi/pull/4862#discussion_r811871242
##########
File path: hudi-flink/src/main/java/org/apache/hudi/source/StreamReadOperator.java
##########
@@ -64,7 +64,7 @@
private static final Logger LOG = LoggerFactory.getLogger(StreamReadOperator.class);
- private static final int MINI_BATCH_SIZE = 1000;
+ private static final int MINI_BATCH_SIZE = 2048;
Review comment:
now i dont have any metrics, but from the code，the time that data is stroed in the memory should be reduce to avoid entering the Old Generation.
https://github.com/apache/hudi/blob/b87e95d621e9fd2d1aebca4c49f599b6437aaf83/hudi-flink/src/main/java/org/apache/hudi/table/format/cow/ParquetColumnarRowSplitReader.java#L306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org