You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 12:00:51 UTC
[GitHub] [flink] rmetzger opened a new pull request #13769: [FLINK-19278] Bump Scala Macros to 2.1.1
rmetzger opened a new pull request #13769:
URL: https://github.com/apache/flink/pull/13769
## What is the purpose of the change
This will add support for newer scala versions, in particlar 2.12.12.
## Verifying this change
Tested also against Scala 2.12: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=8515&view=results
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
## Documentation
There are no other mentions of 2.1.0 in the docs or anywhere else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger merged pull request #13769: [FLINK-19278] Bump Scala Macros to 2.1.1
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13769:
URL: https://github.com/apache/flink/pull/13769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13769: [FLINK-19278] Bump Scala Macros to 2.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13769:
URL: https://github.com/apache/flink/pull/13769#issuecomment-715322699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4939150f6361a6a4f703eacefcd9fa4170b8869",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8190",
"triggerID" : "f4939150f6361a6a4f703eacefcd9fa4170b8869",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4939150f6361a6a4f703eacefcd9fa4170b8869 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13769: [FLINK-19278] Bump Scala Macros to 2.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13769:
URL: https://github.com/apache/flink/pull/13769#issuecomment-715322699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4939150f6361a6a4f703eacefcd9fa4170b8869",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4939150f6361a6a4f703eacefcd9fa4170b8869",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4939150f6361a6a4f703eacefcd9fa4170b8869 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13769: [FLINK-19278] Bump Scala Macros to 2.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13769:
URL: https://github.com/apache/flink/pull/13769#issuecomment-715322699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4939150f6361a6a4f703eacefcd9fa4170b8869",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8190",
"triggerID" : "f4939150f6361a6a4f703eacefcd9fa4170b8869",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4939150f6361a6a4f703eacefcd9fa4170b8869 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13769: [FLINK-19278] Bump Scala Macros to 2.1.1
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13769:
URL: https://github.com/apache/flink/pull/13769#issuecomment-716581321
Thanks for the review. Merging ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13769: [FLINK-19278] Bump Scala Macros to 2.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13769:
URL: https://github.com/apache/flink/pull/13769#issuecomment-715299703
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f4939150f6361a6a4f703eacefcd9fa4170b8869 (Fri Oct 23 12:02:50 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org