You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rangadi (via GitHub)" <gi...@apache.org> on 2023/05/04 17:46:42 UTC

[GitHub] [spark] rangadi commented on a diff in pull request #41037: [SPARK-43032] [SS] [CONNECT] Python SQM bug fix

rangadi commented on code in PR #41037:
URL: https://github.com/apache/spark/pull/41037#discussion_r1185325633


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2466,14 +2466,16 @@ class SparkConnectPlanner(val session: SparkSession) {
 
       case StreamingQueryManagerCommand.CommandCase.GET =>
         val query = session.streams.get(command.getGet)

Review Comment:
   'getGet` sounds off. May be we could rename to `get_query` (changing the name is ok, not an incompatible change at this stage).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org