You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/29 09:12:04 UTC
[GitHub] [doris] starocean999 opened a new pull request, #11335: [FIX]DCHECK error of array functions
starocean999 opened a new pull request, #11335:
URL: https://github.com/apache/doris/pull/11335
# Proposed changes
Issue Number: close (https://github.com/apache/doris/issues/11317)
## Problem Summary:
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 merged pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
xy720 merged PR #11335:
URL: https://github.com/apache/doris/pull/11335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on a diff in pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
starocean999 commented on code in PR #11335:
URL: https://github.com/apache/doris/pull/11335#discussion_r933731907
##########
be/src/vec/functions/array/function_array_binary.h:
##########
@@ -39,7 +39,11 @@ class FunctionArrayBinary : public IFunction {
DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
DCHECK(is_array(arguments[0])) << arguments[0]->get_name();
DCHECK(is_array(arguments[1])) << arguments[1]->get_name();
- DCHECK(arguments[0]->equals(*arguments[1]))
+ auto left_nested_type = remove_nullable(
Review Comment:
a p0 regression test case "select arrays_overlap([1,2,3,null], [3,4,5])" and "select array_intersect([1,2,3], [2,3,4,null])" would trigger the DCHECK because the data type is array<nullable<int>> and array< int >
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #11335: [FIX]DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #11335:
URL: https://github.com/apache/doris/pull/11335#issuecomment-1199272217
Please use `[fix](array).....` pass the ci check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11335:
URL: https://github.com/apache/doris/pull/11335#issuecomment-1200099923
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11335:
URL: https://github.com/apache/doris/pull/11335#issuecomment-1200099929
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
starocean999 commented on PR #11335:
URL: https://github.com/apache/doris/pull/11335#issuecomment-1199308063
> Please use `[fix](array).....` pass the ci check.
thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
xy720 commented on PR #11335:
URL: https://github.com/apache/doris/pull/11335#issuecomment-1200099956
Fast merge because this bug causes regression-test core dump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on a diff in pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
starocean999 commented on code in PR #11335:
URL: https://github.com/apache/doris/pull/11335#discussion_r933731907
##########
be/src/vec/functions/array/function_array_binary.h:
##########
@@ -39,7 +39,11 @@ class FunctionArrayBinary : public IFunction {
DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
DCHECK(is_array(arguments[0])) << arguments[0]->get_name();
DCHECK(is_array(arguments[1])) << arguments[1]->get_name();
- DCHECK(arguments[0]->equals(*arguments[1]))
+ auto left_nested_type = remove_nullable(
Review Comment:
a p0 regression test case "select arrays_overlap([1,2,3,null], [3,4,5])" and "select array_intersect([1,2,3], [2,3,4,null])" would trigger the DCHECK because the data type is array<nullable<int>> and array<int>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on a diff in pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
starocean999 commented on code in PR #11335:
URL: https://github.com/apache/doris/pull/11335#discussion_r933731907
##########
be/src/vec/functions/array/function_array_binary.h:
##########
@@ -39,7 +39,11 @@ class FunctionArrayBinary : public IFunction {
DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
DCHECK(is_array(arguments[0])) << arguments[0]->get_name();
DCHECK(is_array(arguments[1])) << arguments[1]->get_name();
- DCHECK(arguments[0]->equals(*arguments[1]))
+ auto left_nested_type = remove_nullable(
Review Comment:
a p0 regression test case "select arrays_overlap([1,2,3,null], [3,4,5])" and "select array_intersect([1,2,3], [2,3,4,null])" would trigger the DCHECK because the data type is array< nullable< int > > and array< int >
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #11335: [FIX](array)DCHECK error of array functions
Posted by GitBox <gi...@apache.org>.
xy720 commented on code in PR #11335:
URL: https://github.com/apache/doris/pull/11335#discussion_r933445343
##########
be/src/vec/functions/array/function_array_binary.h:
##########
@@ -39,7 +39,11 @@ class FunctionArrayBinary : public IFunction {
DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
DCHECK(is_array(arguments[0])) << arguments[0]->get_name();
DCHECK(is_array(arguments[1])) << arguments[1]->get_name();
- DCHECK(arguments[0]->equals(*arguments[1]))
+ auto left_nested_type = remove_nullable(
Review Comment:
No need to remove_nullable if use_default_implementation_for_nulls() return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org