Re: [PR] KAFKA-20329: Test headers dsl.store.format further (4/N) [kafka]

["mjsax (via GitHub)" <gi...@apache.org>]

mjsax commented on code in PR #21827:
URL: https://github.com/apache/kafka/pull/21827#discussion_r3040994394


##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinTest.java:
##########
@@ -167,11 +172,11 @@ public void shouldFailIfTableIsNotVersioned() {
         );
     }
 
-    @Test
-    public void shouldFailIfTableIsNotVersionedButMaterializationIsInherited() {
+    @ParameterizedTest
+    @ValueSource(booleans = {false, true})
+    public void shouldFailIfTableIsNotVersionedButMaterializationIsInherited(final boolean withHeaders) {
+        setUp(withHeaders);
         final StreamsBuilder builder = new StreamsBuilder();
-        final Properties props = new Properties();
-        props.put(StreamsConfig.TOPOLOGY_OPTIMIZATION_CONFIG, StreamsConfig.NO_OPTIMIZATION);

Review Comment:
   Not sure why we did disable this explicitly as it's disabled by default -- seems we have similar stuff in other tests on this class. Should we also remove it?
   
   Still wondering, why we have this explicit disabling 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org