[GitHub] [superset] eschutho commented on a change in pull request #19421: perf: migrate new dataset models with INSERT FROM

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #19421:
URL: https://github.com/apache/superset/pull/19421#discussion_r840782172



##########
File path: superset/migrations/versions/b8d3a24d9131_new_dataset_models.py
##########
@@ -150,55 +176,66 @@ def fetch_columns_and_metrics(self, session: Session) -> None:
     Base.metadata,
     sa.Column("table_id", sa.ForeignKey("sl_tables.id")),
     sa.Column("column_id", sa.ForeignKey("sl_columns.id")),
+    UniqueConstraint("table_id", "column_id"),

Review comment:
       For people who have already run this migration, we won't get anything new that's added in this update. Can we instead create a new migration for any additions or changes that won't affect performance?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org