[GitHub] [flink] zentol commented on a change in pull request #13464: [FLINK-19307][coordination] Add ResourceTracker

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #13464:
URL: https://github.com/apache/flink/pull/13464#discussion_r499365732



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceTracker.java
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.resourcemanager.slotmanager;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.types.ResourceProfile;
+import org.apache.flink.runtime.slots.ResourceRequirement;
+import org.apache.flink.util.Preconditions;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+/**
+ * Default {@link ResourceTracker} implementation.
+ */
+public class DefaultResourceTracker implements ResourceTracker {
+
+	private static final Logger LOG = LoggerFactory.getLogger(DefaultResourceTracker.class);
+
+	private final Map<JobID, JobScopedResourceTracker> trackers = new LinkedHashMap<>();
+
+	@Override
+	public void notifyResourceRequirements(JobID jobId, Collection<ResourceRequirement> resourceRequirements) {
+		Preconditions.checkNotNull(jobId);
+		Preconditions.checkNotNull(resourceRequirements);
+		LOG.trace("Received notification for job {} having new resource requirements {}.", jobId, resourceRequirements);
+		getOrCreateTracker(jobId).notifyResourceRequirements(resourceRequirements);
+
+		if (resourceRequirements.isEmpty()) {
+			checkWhetherTrackerCanBeRemoved(jobId, trackers.get(jobId));
+		}
+	}
+
+	private void checkWhetherTrackerCanBeRemoved(JobID jobId, JobScopedResourceTracker tracker) {
+		if (tracker.isEmpty()) {
+			LOG.debug("Stopping tracking of resources for job {}.", jobId);
+			trackers.remove(jobId);
+		}
+	}
+
+	@Override
+	public void notifyAcquiredResource(JobID jobId, ResourceProfile resourceProfile) {
+		Preconditions.checkNotNull(jobId);
+		Preconditions.checkNotNull(resourceProfile);
+		LOG.trace("Received notification for job {} having acquired resource {}.", jobId, resourceProfile);
+		getOrCreateTracker(jobId).notifyAcquiredResource(resourceProfile);
+	}
+
+	private JobScopedResourceTracker getOrCreateTracker(JobID jobId) {
+		return trackers.computeIfAbsent(jobId, ignored -> {
+			LOG.debug("Initiating tracking of resources for job {}.", jobId);
+			return new JobScopedResourceTracker(jobId);
+		});
+	}
+
+	@Override
+	public void notifyLostResource(JobID jobId, ResourceProfile resourceProfile) {
+		Preconditions.checkNotNull(jobId);
+		Preconditions.checkNotNull(resourceProfile);
+		JobScopedResourceTracker tracker = trackers.get(jobId);
+
+		// during shutdown the tracker is cleared before task executors are unregistered,
+		// to prevent the loss of resources triggering new allocations
+		if (tracker != null) {
+			LOG.trace("Received notification for job {} having lost resource {}.", jobId, resourceProfile);
+			tracker.notifyLostResource(resourceProfile);
+
+			checkWhetherTrackerCanBeRemoved(jobId, tracker);
+		} else {
+			LOG.trace("Received notification for job {} having lost resource {}, but no such job was tracked.", jobId, resourceProfile);
+		}
+	}
+
+	@Override
+	public void clear() {
+		trackers.clear();
+	}
+
+	@Override
+	public Map<JobID, Collection<ResourceRequirement>> getRequiredResources() {
+		Map<JobID, Collection<ResourceRequirement>> requiredResources = new LinkedHashMap<>();
+		for (Map.Entry<JobID, JobScopedResourceTracker> jobIDJobScopedRequirementsTrackerEntry : trackers.entrySet()) {
+			Collection<ResourceRequirement> exceedingOrRequiredResources = jobIDJobScopedRequirementsTrackerEntry.getValue().getRequiredResources();

Review comment:
       leftovers from a previous version where this method could return positive (==required) and negative (==excess) counts; will rename it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org