[GitHub] [trafficcontrol] zrhoffman commented on pull request #4790: Add Topology ATS Config Generation

[GitBox <gi...@apache.org>]

zrhoffman commented on pull request #4790:
URL: https://github.com/apache/trafficcontrol/pull/4790#issuecomment-668840690


   `atscfg.TestMakeParentDotConfigTopologies` fails:
   
   ```go
   --- FAIL: TestMakeParentDotConfigTopologies (0.00s)
       parentdotconfig_test.go:488: expected parent 'dest_domain=ds0.example.net', actual: '# DO NOT EDIT - Generated for myserver by myToolName (https://myto.example.net) on Tue Aug 4 21:44:15 UTC 2020
           dest_domain=ds0.example.net port=80 parent=""  round_robin=consistent_hash go_direct=false qstring=myQStringHandlingParam
           dest_domain=. parent="" round_robin=consistent_hash go_direct=false qstring=myQstringParam
           '
   --- FAIL: TestMakeParentDotConfigTopologiesCapabilities (0.00s)
       parentdotconfig_test.go:721: expected parent 'dest_domain=ds0.example.net' without required capabilities: '# DO NOT EDIT - Generated for myserver by myToolName (https://myto.example.net) on Tue Aug 4 21:44:15 UTC 2020
           dest_domain=. parent="" round_robin=consistent_hash go_direct=false qstring=myQstringParam
           '
       parentdotconfig_test.go:724: expected parent 'dest_domain=ds1.example.net' with necessary required capabilities, actual: '# DO NOT EDIT - Generated for myserver by myToolName (https://myto.example.net) on Tue Aug 4 21:44:15 UTC 2020
           dest_domain=. parent="" round_robin=consistent_hash go_direct=false qstring=myQstringParam
           '
   FAIL
   exit status 1
   FAIL    github.com/apache/trafficcontrol/lib/go-atscfg  0.007s
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org