You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2020/03/28 01:48:21 UTC
[GitHub] [felix-dev] ghenzler commented on a change in pull request #11:
[FELIX-6246] Packaged External Library Packages inside referenced Health
Check Bundles
ghenzler commented on a change in pull request #11: [FELIX-6246] Packaged External Library Packages inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#discussion_r399603689
##########
File path: healthcheck/core/bnd.bnd
##########
@@ -1,17 +1,8 @@
-Bundle-Category: healthcheck
-
-Bundle-Description: ${project.description}
-
-Bundle-DocURL: https://felix.apache.org
-
-Bundle-License: Apache License, Version 2.0
-
-Bundle-Vendor: The Apache Software Foundation
-
-Import-Package: org.quartz*;resolution:="optional", *
-
-Conditional-Package: org.apache.felix.utils.*
-
--removeheaders:\
- Include-Resource,\
- Private-Package
+Bundle-Category : healthcheck
+Bundle-Description : ${project.description}
+Bundle-DocURL : https://felix.apache.org
+Bundle-License : Apache License, Version 2.0
+Bundle-Vendor : The Apache Software Foundation
+Import-Package : org.quartz*;resolution:="optional", *
+-conditionalpackage : org.apache.felix.utils.*, org.apache.commons.lang3.*
Review comment:
Checked a build with and without conditional package - it looks like the whole commons lang library is pulled in ATM and hence the size of the hc core bundle is just the regular jar + the 435KB from commons lang ending up at a similar memory footprint. @amitjoy Can you do some tests on how to really get the file size down? (the optional include only taking what's needed works for org.apache.felix.utils.*, not sure why it does not for org.apache.commons.lang3.*)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services