[GitHub] [pulsar] hangc0276 commented on a diff in pull request #20366: [fix][offload] fix offload metrics error

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 commented on code in PR #20366:
URL: https://github.com/apache/pulsar/pull/20366#discussion_r1210085410


##########
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java:
##########
@@ -339,6 +339,42 @@ public String getPersistenceNamingEncoding() {
         }
     }
 
+    /**
+     * get topic full name from managedLedgerName.
+     *
+     * @return the topic full name, format -> domain://tenant/namespace/topic
+     */
+    public static String fromPersistenceNamingEncoding(String mlName) {

Review Comment:
   Please add a unit test to cover this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org