You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/10/17 15:15:33 UTC

[jira] [Commented] (THRIFT-2788) Java client and server does not enable tcp keep alive.

    [ https://issues.apache.org/jira/browse/THRIFT-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175039#comment-14175039 ] 

ASF GitHub Bot commented on THRIFT-2788:
----------------------------------------

GitHub user abadcafe opened a pull request:

    https://github.com/apache/thrift/pull/248

    THRIFT-2788: enable TCP keep alive for sockets in java lib.

    Both client and server sockets in Java were not enable tcp keepalive.
    
    This is important for reap dead tcp connections. If not enabled, the process can not be notified appropriately while remote peer crashed or connection interrupted


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ops-baidu/thrift THRIFT-2788

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #248
    
----
commit 3299a0a077d308ba56d43639a3dbff68c911c10f
Author: Lei Feiwei <le...@baidu.com>
Date:   2014-10-17T13:11:04Z

    enable TCP keep alive for sockets in java lib.

----


> Java client and server does not enable tcp keep alive.
> ------------------------------------------------------
>
>                 Key: THRIFT-2788
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2788
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.1
>            Reporter: Lei FW
>
> Both client and server sockets in Java were not enable tcp keepalive.
> This is important for reap dead tcp connections. If not enabled, the process can not be notified appropriately while remote peer crashed or connection interrupted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)