You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/08 11:37:00 UTC

[jira] [Commented] (FLINK-2054) StreamOperator rework removed copy calls when passing output to a chained operator

    [ https://issues.apache.org/jira/browse/FLINK-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576817#comment-14576817 ] 

ASF GitHub Bot commented on FLINK-2054:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/803

    [FLINK-2054] Add object-reuse switch for streaming

    The switch was already there: enableObjectReuse() in ExecutionConfig.
    This was simply not considered by the streaming runtime. This change now
    draws a copy before forwarding an element to a chained operator when
    object reuse is disabled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink streaming-reuse-switch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/803.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #803
    
----
commit c1896ef6355f47f89215acff7eba9f944c461196
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2015-06-08T09:32:27Z

    [FLINK-2054] Add object-reuse switch for streaming
    
    The switch was already there: enableObjectReuse() in ExecutionConfig.
    This was simply not considered by the streaming runtime. This change now
    draws a copy before forwarding an element to a chained operator when
    object reuse is disabled.

----


> StreamOperator rework removed copy calls when passing output to a chained operator
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-2054
>                 URL: https://issues.apache.org/jira/browse/FLINK-2054
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>            Reporter: Gyula Fora
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>
> Before the recent rework of stream operators to be push based, operators held the semantics that any input (and also output to be specific) will not be mutated afterwards. This was achieved by simply copying records that were passed to other chained operators.
> This feature has been removed thus introducing a major break in the operator mutability guarantees. 
> To make chaining viable in all cases (and to prevent hidden bugs) we need to reintroduce the copying logic. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)