[GitHub] [airflow] uranusjr commented on a diff in pull request #25788: Properly check the existence of missing mapped TIs

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #25788:
URL: https://github.com/apache/airflow/pull/25788#discussion_r949779317


##########
airflow/models/dagrun.py:
##########
@@ -729,6 +726,10 @@ def _get_ready_tis(
                     additional_tis.extend(expanded_tis[1:])
                 expansion_happened = True
             if schedulable.state in SCHEDULEABLE_STATES:
+                if schedulable.task.is_mapped:
+                    task = cast("MappedOperator", schedulable.task)

Review Comment:
   ```suggestion
                   task = schedulable.task
                   if isinstance(task, MappedOperator):
   ```
   
   since we are dealing with MappedOperator explicitly, using `isinstance` is more correct here.
   
   Why are we putting this method on MappedOperator though? The logic does not really need much from the operator and the previous way putting the logic on DagRun makes more sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org