[GitHub] [kafka] guozhangwang commented on a diff in pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

["guozhangwang (via GitHub)" <gi...@apache.org>]

guozhangwang commented on code in PR #13318:
URL: https://github.com/apache/kafka/pull/13318#discussion_r1157431834


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -140,16 +134,15 @@ public void run() {
             log.info("State updater thread started");
             try {
                 while (isRunning.get()) {
-                    try {
-                        runOnce();
-                    } catch (final InterruptedException | InterruptException interruptedException) {
-                        return;
-                    }
+                    // in state updater we never interrupt the thread
+                    // or wakeup the consumer, hence any of
+                    // InterruptException / WakeupException
+                    // should never happen
+                    runOnce();

Review Comment:
   ack, will remove upon merging



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org