You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2018/05/28 14:50:49 UTC

Go build failure

Hi all,

The following fails for me with "./gradlew check":

Execution failed for task ':beam-sdks-go:vet'.
> Build failed due to return code 1 of:
  Command:
   /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet
/home/coheig/src/apache/beam/sdks/go/test
/home/coheig/src/apache/beam/sdks/go/pkg
/home/coheig/src/apache/beam/sdks/go/data
/home/coheig/src/apache/beam/sdks/go/cmd
/home/coheig/src/apache/beam/sdks/go/build
/home/coheig/src/apache/beam/sdks/go/examples
/home/coheig/src/apache/beam/sdks/go/container
  Env:
   GOEXE=
   GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
   GOROOT=/home/coheig/.gradle/go/binary/1.10/go
   GOOS=linux
   GOARCH=amd64

Should the gradle configuration be setting up Go, or is it a requirement to
install it separately? Or is this failure caused by something else?

Thanks,

Colm.


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: Go build failure

Posted by Henning Rohde <he...@google.com>.
Hi Colm,

 The gradle plugin installs Go for you. I tried "./gradlew check" on my
machine: the error is "go vet" itself failing due to analyzing our
dependencies under vendor:

/Users/herohde/go/src/
github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47:
Fprintln arg list ends with redundant newline

/Users/herohde/go/src/
github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54:
unreachable code

/Users/herohde/go/src/
github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276:
unreachable code
[...]

Not sure whether this is something we can fix in our configuration or
whether it's rather a bug in the gogradle plugin. Given that there are no
go vet problems in our code, we'd want that check to pass. Feel free to
open a bug and I can take a deeper look at it.

For now, it seems you'd have to exclude the go targets for "./gradlew
check". Note that if you just want to build the code, you should run
"./gradlew build" which works.

Henning

On Mon, May 28, 2018 at 7:58 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:

> Hi Colm,
>
> it worked for me (with build) during the weekend.
>
> Do you have golang installed on your machine ?
>
> Regards
> JB
>
> On 28/05/2018 16:50, Colm O hEigeartaigh wrote:
> > Hi all,
> >
> > The following fails for me with "./gradlew check":
> >
> > Execution failed for task ':beam-sdks-go:vet'.
> >> Build failed due to return code 1 of:
> >   Command:
> >    /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet
> > /home/coheig/src/apache/beam/sdks/go/test
> > /home/coheig/src/apache/beam/sdks/go/pkg
> > /home/coheig/src/apache/beam/sdks/go/data
> > /home/coheig/src/apache/beam/sdks/go/cmd
> > /home/coheig/src/apache/beam/sdks/go/build
> > /home/coheig/src/apache/beam/sdks/go/examples
> > /home/coheig/src/apache/beam/sdks/go/container
> >   Env:
> >    GOEXE=
> >    GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
> >    GOROOT=/home/coheig/.gradle/go/binary/1
> <https://goto.google.com/binary/1>.10/go
> >    GOOS=linux
> >    GOARCH=amd64
> >
> > Should the gradle configuration be setting up Go, or is it a requirement
> > to install it separately? Or is this failure caused by something else?
> >
> > Thanks,
> >
> > Colm.
> >
> >
> > --
> > Colm O hEigeartaigh
> >
> > Talend Community Coder
> > http://coders.talend.com
>
> --
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>

Re: Go build failure

Posted by Colm O hEigeartaigh <co...@apache.org>.
Thanks guys, I've created the following JIRA:

https://issues.apache.org/jira/browse/BEAM-4422

Colm.

On Mon, May 28, 2018 at 5:36 PM, Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:

> ./gradlew build works but not check due to go:vet task.
>
> Let's check with Henning.
>
> Regards
> JB
>
> On 28/05/2018 16:57, Jean-Baptiste Onofré wrote:
> > Hi Colm,
> >
> > it worked for me (with build) during the weekend.
> >
> > Do you have golang installed on your machine ?
> >
> > Regards
> > JB
> >
> > On 28/05/2018 16:50, Colm O hEigeartaigh wrote:
> >> Hi all,
> >>
> >> The following fails for me with "./gradlew check":
> >>
> >> Execution failed for task ':beam-sdks-go:vet'.
> >>> Build failed due to return code 1 of:
> >>   Command:
> >>    /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet
> >> /home/coheig/src/apache/beam/sdks/go/test
> >> /home/coheig/src/apache/beam/sdks/go/pkg
> >> /home/coheig/src/apache/beam/sdks/go/data
> >> /home/coheig/src/apache/beam/sdks/go/cmd
> >> /home/coheig/src/apache/beam/sdks/go/build
> >> /home/coheig/src/apache/beam/sdks/go/examples
> >> /home/coheig/src/apache/beam/sdks/go/container
> >>   Env:
> >>    GOEXE=
> >>    GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
> >>    GOROOT=/home/coheig/.gradle/go/binary/1.10/go
> >>    GOOS=linux
> >>    GOARCH=amd64
> >>
> >> Should the gradle configuration be setting up Go, or is it a requirement
> >> to install it separately? Or is this failure caused by something else?
> >>
> >> Thanks,
> >>
> >> Colm.
> >>
> >>
> >> --
> >> Colm O hEigeartaigh
> >>
> >> Talend Community Coder
> >> http://coders.talend.com
> >
>
> --
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>



-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: Go build failure

Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
./gradlew build works but not check due to go:vet task.

Let's check with Henning.

Regards
JB

On 28/05/2018 16:57, Jean-Baptiste Onofré wrote:
> Hi Colm,
> 
> it worked for me (with build) during the weekend.
> 
> Do you have golang installed on your machine ?
> 
> Regards
> JB
> 
> On 28/05/2018 16:50, Colm O hEigeartaigh wrote:
>> Hi all,
>>
>> The following fails for me with "./gradlew check":
>>
>> Execution failed for task ':beam-sdks-go:vet'.
>>> Build failed due to return code 1 of:
>>   Command:
>>    /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet
>> /home/coheig/src/apache/beam/sdks/go/test
>> /home/coheig/src/apache/beam/sdks/go/pkg
>> /home/coheig/src/apache/beam/sdks/go/data
>> /home/coheig/src/apache/beam/sdks/go/cmd
>> /home/coheig/src/apache/beam/sdks/go/build
>> /home/coheig/src/apache/beam/sdks/go/examples
>> /home/coheig/src/apache/beam/sdks/go/container
>>   Env:
>>    GOEXE=
>>    GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
>>    GOROOT=/home/coheig/.gradle/go/binary/1.10/go
>>    GOOS=linux
>>    GOARCH=amd64
>>
>> Should the gradle configuration be setting up Go, or is it a requirement
>> to install it separately? Or is this failure caused by something else?
>>
>> Thanks,
>>
>> Colm.
>>
>>
>> -- 
>> Colm O hEigeartaigh
>>
>> Talend Community Coder
>> http://coders.talend.com
> 

-- 
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Go build failure

Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Colm,

it worked for me (with build) during the weekend.

Do you have golang installed on your machine ?

Regards
JB

On 28/05/2018 16:50, Colm O hEigeartaigh wrote:
> Hi all,
> 
> The following fails for me with "./gradlew check":
> 
> Execution failed for task ':beam-sdks-go:vet'.
>> Build failed due to return code 1 of:
>   Command:
>    /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet
> /home/coheig/src/apache/beam/sdks/go/test
> /home/coheig/src/apache/beam/sdks/go/pkg
> /home/coheig/src/apache/beam/sdks/go/data
> /home/coheig/src/apache/beam/sdks/go/cmd
> /home/coheig/src/apache/beam/sdks/go/build
> /home/coheig/src/apache/beam/sdks/go/examples
> /home/coheig/src/apache/beam/sdks/go/container
>   Env:
>    GOEXE=
>    GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
>    GOROOT=/home/coheig/.gradle/go/binary/1.10/go
>    GOOS=linux
>    GOARCH=amd64
> 
> Should the gradle configuration be setting up Go, or is it a requirement
> to install it separately? Or is this failure caused by something else?
> 
> Thanks,
> 
> Colm.
> 
> 
> -- 
> Colm O hEigeartaigh
> 
> Talend Community Coder
> http://coders.talend.com

-- 
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com