[GitHub] [spark] yaooqinn commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726708161



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
##########
@@ -198,4 +198,14 @@ class KubernetesConfSuite extends SparkFunSuite {
     assert(driverConf.nodeSelector === CUSTOM_NODE_SELECTOR)
     assert(driverConf.driverNodeSelector === CUSTOM_DRIVER_NODE_SELECTOR)
   }
+
+  test("SPARK-36059: Set driver.scheduler and excutor.scheduler") {

Review comment:
       can we add a test when these configurations are not specified.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org