You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2017/04/11 16:48:19 UTC

[2/3] tinkerpop git commit: Merge branch 'TINKERPOP-1663' into tp32

Merge branch 'TINKERPOP-1663' into tp32

Conflicts:
	docs/src/upgrade/release-3.2.x-incubating.asciidoc


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/e4372b2d
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/e4372b2d
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/e4372b2d

Branch: refs/heads/master
Commit: e4372b2dce84cbbb57583af7e807185e8ff4c43d
Parents: 26c6302 a4c652a
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Tue Apr 11 08:22:58 2017 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Tue Apr 11 08:22:58 2017 -0400

----------------------------------------------------------------------
 .../src/reference/gremlin-applications.asciidoc | 21 +++++++
 .../upgrade/release-3.2.x-incubating.asciidoc   | 22 +++++++
 .../tinkerpop/gremlin/server/Settings.java      | 11 ++++
 .../server/op/AbstractEvalOpProcessor.java      | 23 +++++++-
 .../tinkerpop/gremlin/server/op/OpLoader.java   |  8 +++
 .../gremlin/server/op/session/Session.java      |  5 +-
 .../server/op/session/SessionOpProcessor.java   |  7 +++
 .../server/op/standard/StandardOpProcessor.java | 18 ++++++
 .../AbstractGremlinServerIntegrationTest.java   |  5 ++
 .../server/GremlinServerIntegrateTest.java      | 62 ++++++++++++++++++++
 10 files changed, 176 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e4372b2d/docs/src/reference/gremlin-applications.asciidoc
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e4372b2d/docs/src/upgrade/release-3.2.x-incubating.asciidoc
----------------------------------------------------------------------
diff --cc docs/src/upgrade/release-3.2.x-incubating.asciidoc
index f0bbba2,8079cdd..c85cc3c
--- a/docs/src/upgrade/release-3.2.x-incubating.asciidoc
+++ b/docs/src/upgrade/release-3.2.x-incubating.asciidoc
@@@ -32,16 -32,28 +32,38 @@@ Please see the link:https://github.com/
  Upgrading for Users
  ~~~~~~~~~~~~~~~~~~~
  
 +Authentication Configuration
 +^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 +
 +The server settings previously used `authentication.className` to set an authenticator for the the two provided
 +authentication handler and channelizer classes to use. This has been deprecated in favor of `authentication.authenticator`.
 +A class that extends `AbstractAuthenticationHandler` may also now be provided as `authentication.authenticationHandler`
 +to be used in either of the provided channelizer classes to handle the provided authenticator
 +
 +See: https://issues.apache.org/jira/browse/TINKERPOP-1657[TINKERPOP-1657]
 +
+ Default Maximum Parameters
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^
+ 
+ It was learned that compilation for scripts with large numbers of parameters is more expensive than those with less
+ parameters. It therefore becomes possible to make some mistakes with how Gremlin Server is used. A new setting on
+ the `StandardOpProcessor` and `SessionOpProcessor` called `maxParameters` controls the number of parameters that can
+ be passed in on a request. This setting is defaulted to sixteen.
+ 
+ Users upgrading to this version may notice errors in their applications if they use more than sixteen parameters. To
+ fix this problem simply reconfigure Gremlin Server with a configuration as follows:
+ 
+ [source,yaml]
+ ----
+ processors:
+   - { className: org.apache.tinkerpop.gremlin.server.op.session.SessionOpProcessor, config: { maxParameters: 64 }}
+   - { className: org.apache.tinkerpop.gremlin.server.op.standard.StandardOpProcessor, config: { maxParameters: 64 }}
+ ----
+ 
+ The above configuration allows sixty-four parameters to be passed on each request.
+ 
+ See: link:https://issues.apache.org/jira/browse/TINKERPOP-1663[TINKERPOP-1663]
+ 
  GremlinScriptEngine Metrics
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e4372b2d/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java
----------------------------------------------------------------------