You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/29 14:35:58 UTC
[GitHub] [superset] codecov[bot] commented on pull request #22173: feat: Uses new table component in Drill to Detail
codecov[bot] commented on PR #22173:
URL: https://github.com/apache/superset/pull/22173#issuecomment-1330744420
# [Codecov](https://codecov.io/gh/apache/superset/pull/22173?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22173](https://codecov.io/gh/apache/superset/pull/22173?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fda2b66) into [master](https://codecov.io/gh/apache/superset/commit/eba7b3d074350c3429778259baef19b7995f60ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eba7b3d) will **increase** coverage by `0.04%`.
> The diff coverage is `45.71%`.
```diff
@@ Coverage Diff @@
## master #22173 +/- ##
==========================================
+ Coverage 66.86% 66.90% +0.04%
==========================================
Files 1840 1845 +5
Lines 70160 70234 +74
Branches 7657 7679 +22
==========================================
+ Hits 46909 46989 +80
+ Misses 21281 21254 -27
- Partials 1970 1991 +21
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.79% <45.71%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../components/Chart/DrillDetail/DrillDetailModal.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxEZXRhaWwvRHJpbGxEZXRhaWxNb2RhbC50c3g=) | `92.30% <ø> (ø)` | |
| [...ts/Table/header-renderers/HeaderWithRadioGroup.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvaGVhZGVyLXJlbmRlcmVycy9IZWFkZXJXaXRoUmFkaW9Hcm91cC50c3g=) | `0.00% <0.00%> (ø)` | |
| [...c/components/Chart/DrillDetail/DrillDetailPane.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxEZXRhaWwvRHJpbGxEZXRhaWxQYW5lLnRzeA==) | `75.53% <42.10%> (-7.19%)` | :arrow_down: |
| [...ponents/Table/cell-renderers/BooleanCell/index.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvY2VsbC1yZW5kZXJlcnMvQm9vbGVhbkNlbGwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...components/Table/cell-renderers/NullCell/index.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvY2VsbC1yZW5kZXJlcnMvTnVsbENlbGwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...components/Table/cell-renderers/TimeCell/index.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvY2VsbC1yZW5kZXJlcnMvVGltZUNlbGwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Table/index.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvaW5kZXgudHN4) | `74.02% <100.00%> (+10.86%)` | :arrow_up: |
| [...nd/src/hooks/useTruncation/useCSSTextTruncation.ts](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL3VzZVRydW5jYXRpb24vdXNlQ1NTVGV4dFRydW5jYXRpb24udHM=) | `69.23% <0.00%> (-30.77%)` | :arrow_down: |
| [...Filters/FilterBar/FilterControls/FilterDivider.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckRpdmlkZXIudHN4) | `81.48% <0.00%> (-18.52%)` | :arrow_down: |
| [...rontend/src/components/DropdownContainer/index.tsx](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25Db250YWluZXIvaW5kZXgudHN4) | `78.57% <0.00%> (-1.43%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/22173/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org