You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "nikam14 (via GitHub)" <gi...@apache.org> on 2023/05/03 07:03:21 UTC

[GitHub] [rocketmq] nikam14 opened a new issue, #6684: [Enhancement] Unused Code

nikam14 opened a new issue, #6684:
URL: https://github.com/apache/rocketmq/issues/6684

   ### Before Creating the Enhancement Request
   
   <!-- Most of issues should be classified as bug or feature request. An issue should be considered as an enhancement when it proposes improvements to existing functionality or user experience, without necessarily introducing new features or fixing existing bugs. -->
   
   - [x] I have confirmed that this should be classified as an enhancement rather than a bug/feature.
   
   ### Summary
   
   location - acl/src/main/java/org/apache/rocketmq/acl/common/AclUtils.java
   line - 147
   screenshot - 
   ![rocketmq](https://user-images.githubusercontent.com/55378196/235850429-2f821aa5-3a4d-4602-b8bd-b078ae43c672.PNG)
   this code not used or unnecessary . 
   
   <!-- A clear and concise description of the enhancement you would like to see in the project. -->
   
   ### Motivation
   
   to improve code quality
   <!-- Explain why you believe this enhancement is necessary, and how it benefits the project and community. Include any specific use cases that you have in mind. -->
   
   ### Describe the Solution You'd Like
   remove the if block.
   <!-- Describe the enhancement you propose, detailing the change and implementation steps involved. If you have multiple solutions, please list them separately. -->
   
   ### Describe Alternatives You've Considered
   no alternatives
   <!-- List any alternative enhancements or implementations you have considered, and explain why they may not be as effective or appropriate. -->
   
   ### Additional Context
   no  additional context
   <!-- Add any relevant context, screenshots, prototypes, or other supplementary information to help illustrate the enhancement. -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] aaron-ai closed issue #6684: [Enhancement] Unused Code

Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai closed issue #6684: [Enhancement] Unused Code
URL: https://github.com/apache/rocketmq/issues/6684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] mxsm commented on issue #6684: [Enhancement] Unused Code

Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on issue #6684:
URL: https://github.com/apache/rocketmq/issues/6684#issuecomment-1532898262

   @nikam14  welcome submit a pr to fix it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org