You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/09/26 04:06:15 UTC

[GitHub] lushuifeng opened a new pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

lushuifeng opened a new pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481
 
 
   Details in DRILL-6763:
   
   Here is the descriptions of the change:
   1. add system option `exec.optimize_function_compilation` to toggle to state of this functionality.
   2. codegen is changed by declaring setter method in EvaluationVisitor#visitXXXconstants
   3. the member declared in step2 is initialized when the instance of the class is created in XXBatch and others
   4. attachment is the code of the same query mentioned in DRILL-6763 generated by setting the value of exec.optimize_function_compilation to true
   @arina-ielchiieva @vdiravka Would you please take a look?
   What kind of unit tests should be added?
   [query.txt](https://github.com/apache/drill/files/2418035/query.txt)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services