You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:41:47 UTC
[GitHub] [druid] FrankChen021 opened a new issue #10007: what's the purpose of druid.server.maxSize ? can we delete it ?
FrankChen021 opened a new issue #10007:
URL: https://github.com/apache/druid/issues/10007
I tried to solve #9998 today and found this parameter seems redundant.
According to the [doc](https://druid.apache.org/docs/latest/configuration/index.html#historical-general-configuration),
> This is not a limit that Historical processes actually enforces, just a value published to the Coordinator process so it can plan accordingly.
There're two problems here
1. Confusion
Why don't we use the sum of all the `maxSize` in `druid.segmentCache.locations` ?
What if this value is less than the sum of `maxSize` in `druid.segmentCache.locations` ?
What if this value is greater than the sum of `maxSize` in `druid.segmentCache.locations` ?
Apparently, it's value should be the same as the total max size of all disks.
2. Redundant configuration
If there're several disks configured, user has to sum the maxSize together by himself to fill this parameter. It's boring.
I checked relevant code, and found no any other special purposes for this parameter. It seems there's no need to keep this parameter. **Historical node should calculates the total max size based on user's configuration during start up.**
Can we delete this parameter ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] a2l007 commented on issue #10007: what's the purpose of druid.server.maxSize ? can we delete it ?
Posted by GitBox <gi...@apache.org>.
a2l007 commented on issue #10007:
URL: https://github.com/apache/druid/issues/10007#issuecomment-669210718
I have a prototype ready that will default the server.maxSize property to the sum of the maxSize values in druid.segmentCache.locations. The PR would be available once requisite testing is completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on issue #10007: what's the purpose of druid.server.maxSize ? can we delete it ?
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on issue #10007:
URL: https://github.com/apache/druid/issues/10007#issuecomment-669627065
@a2l007 Great. I intended to solve this problem but I was working on other problems all the time. Looking forward to your patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 closed issue #10007: what's the purpose of druid.server.maxSize ? can we delete it ?
Posted by GitBox <gi...@apache.org>.
FrankChen021 closed issue #10007:
URL: https://github.com/apache/druid/issues/10007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org