[GitHub] [iceberg] haizhou-zhao commented on issue #6798: [Rest Catalog Open API] Usage of "oneof" in the definition

["haizhou-zhao (via GitHub)" <gi...@apache.org>]

haizhou-zhao commented on issue #6798:
URL: https://github.com/apache/iceberg/issues/6798#issuecomment-1426168486

   @Fokko Thanks for your response. If I understand you correctly, both of us found that the generated models from the provided OpenAPI spec is different from the existing models provided by iceberg java library, and therefore might be unusable to parse the existing schema and other Iceberg Metadata. So in summary, it sounds like the current OpenAPI spec is "incorrect". Let me know this is the right claim.
   
   First, thanks for bringing to my attention this PR https://github.com/apache/iceberg/pull/6672, I think this is a worthy effort and will improve the quality of Iceberg's Open API spec in the long run.
   
   Secondly, yes, I'm considering using iceberg-core library to parse Iceberg Metadata (including schema information). Just like what you experienced, I don't think the current OpenAPI generated model could be used to parse an Iceberg Metadata File, then using the original java lib sounds like a good temporary work around.
   
   Finally, since we talked about potentially correct the OpenAPI spec, I'd like to learn more about the "endeavor" we need to take to update it. Regarding backward compatibility, I'm trying to make a bold guess: if the current OpenAPI spec defined model is not usable for parsing Iceberg Metadata, then perhaps not very much people are actually using it? I'm trying to get an idea whether the current OpenAPI spec is closer to alpha testing, or it's fully production launched. If it is just in alpha testing stage, then perhaps backward compatibility is not very important?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org