[GitHub] piiswrong commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests
URL: https://github.com/apache/incubator-mxnet/pull/10216#discussion_r176864388
 
 

 ##########
 File path: python/mxnet/contrib/onnx/_import/import_model.py
 ##########
 @@ -46,5 +43,5 @@ def import_model(model_file):
     except ImportError:
         raise ImportError("Onnx and protobuf need to be installed")
     model_proto = onnx.load(model_file)
-    sym, params = graph.from_onnx(model_proto.graph)
-    return sym, params
+    sym, arg_params, aux_params = graph.from_onnx(model_proto.graph)
+    return sym, arg_params, aux_params
 
 Review comment:
   This is API breakage. I understand this is necessary because the previous implementation was wrong. But let's try to not merge code before they are ready next time.
   @nswamy 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services