You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/16 20:07:16 UTC

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #4168: wqueue: Fix typos

hartmannathan opened a new pull request #4168:
URL: https://github.com/apache/incubator-nuttx/pull/4168


   ## Summary
   
   ```
   include/nuttx/wqueue.h:
   libs/libc/wqueue/work_cancel.c:
   libs/libc/wqueue/work_queue.c:
   sched/wqueue/kwork_cancel.c:
   sched/wqueue/kwork_queue.c:
   
       * Fix spelling, grammar, and typos.
       * Improve wording in a few areas.
   ```
   
   ## Impact
   
   These changes affect comments only. No functional changes.
   
   ## Testing
   
   nxstyle


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4168: wqueue: Fix typos

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4168:
URL: https://github.com/apache/incubator-nuttx/pull/4168#discussion_r671536180



##########
File path: libs/libc/wqueue/work_cancel.c
##########
@@ -44,12 +44,12 @@
  *
  * Description:
  *   Cancel previously queued work.  This removes work from the work queue.
- *   After work has been cancelled, it may be re-queue by calling
+ *   After work has been cancelled, it may be re-queued by calling

Review comment:
       ```suggestion
    *   After work has been cancelled, it may be requeued by calling
   ```
   nit: This is both written as "re-queue" and "requeue". For consistency, we'd better decide for a single one. According to Google, the one that has the most references is "requeue". So I'd go with that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4168: wqueue: Fix typos

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4168:
URL: https://github.com/apache/incubator-nuttx/pull/4168#discussion_r671536180



##########
File path: libs/libc/wqueue/work_cancel.c
##########
@@ -44,12 +44,12 @@
  *
  * Description:
  *   Cancel previously queued work.  This removes work from the work queue.
- *   After work has been cancelled, it may be re-queue by calling
+ *   After work has been cancelled, it may be re-queued by calling

Review comment:
       ```suggestion
    *   After work has been cancelled, it may be requeued by calling
   ```
   nit: This is both written as "re-queue" and "requeue". For consistency, we need to decide for a single one. According to Google, the one that has the most references is "requeue". So I'd go with that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #4168: wqueue: Fix typos

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #4168:
URL: https://github.com/apache/incubator-nuttx/pull/4168


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #4168: wqueue: Fix typos

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #4168:
URL: https://github.com/apache/incubator-nuttx/pull/4168#discussion_r671539875



##########
File path: libs/libc/wqueue/work_cancel.c
##########
@@ -44,12 +44,12 @@
  *
  * Description:
  *   Cancel previously queued work.  This removes work from the work queue.
- *   After work has been cancelled, it may be re-queue by calling
+ *   After work has been cancelled, it may be re-queued by calling

Review comment:
       Good catch! Fixed, see latest force push




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org