You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 07:10:14 UTC
[GitHub] [airflow] potiuk opened a new pull request #11674: Security scans are also selective now
potiuk opened a new pull request #11674:
URL: https://github.com/apache/airflow/pull/11674
The security scans take a long time, especially for python code
- it is about ~18 minutes now. This PR reduces strain on the
GitHub actions by only running the scan in pull requests
when any of python/javascript code changed respectively.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11674: Security scans are also selective now
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11674:
URL: https://github.com/apache/airflow/pull/11674#discussion_r508299868
##########
File path: scripts/ci/selective_ci_checks.sh
##########
@@ -185,6 +200,34 @@ function count_changed_files() {
echo "${CHANGED_FILES}" | grep -c -E "$(get_regexp_from_patterns)" || true
}
+function check_if_python_security_scans_should_be_run() {
+ local pattern_array=(
+ "^airflow/.*\.py"
Review comment:
setup.py here too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11674: Security scans are also selective now
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11674:
URL: https://github.com/apache/airflow/pull/11674#issuecomment-712695845
[The Workflow run](https://github.com/apache/airflow/actions/runs/317124545) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11674: Security scans are also selective now
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11674:
URL: https://github.com/apache/airflow/pull/11674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11674: Security scans are also selective now
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11674:
URL: https://github.com/apache/airflow/pull/11674#issuecomment-712676838
Almost the last optimization I can think of :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org