You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/11 06:10:19 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6024: fs/fcntl: add O_APPEND flag judge in fcntl
xiaoxiang781216 opened a new pull request, #6024:
URL: https://github.com/apache/incubator-nuttx/pull/6024
## Summary
## Impact
fcntl with O_APPEND
## Testing
local testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6024: fs/fcntl: add O_APPEND flag judge in fcntl
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6024:
URL: https://github.com/apache/incubator-nuttx/pull/6024#discussion_r847554241
##########
fs/vfs/fs_fcntl.c:
##########
@@ -150,6 +150,11 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap)
oflags &= (FFCNTL & ~O_NONBLOCK);
filep->f_oflags &= ~(FFCNTL & ~O_NONBLOCK);
filep->f_oflags |= oflags;
+
+ if (filep->f_oflags & O_APPEND)
Review Comment:
```suggestion
if ((filep->f_oflags & O_APPEND) != 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6024: fs/fcntl: add O_APPEND flag judge in fcntl
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6024:
URL: https://github.com/apache/incubator-nuttx/pull/6024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6024: fs/fcntl: add O_APPEND flag judge in fcntl
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6024:
URL: https://github.com/apache/incubator-nuttx/pull/6024#discussion_r847602478
##########
fs/vfs/fs_fcntl.c:
##########
@@ -150,6 +150,11 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap)
oflags &= (FFCNTL & ~O_NONBLOCK);
filep->f_oflags &= ~(FFCNTL & ~O_NONBLOCK);
filep->f_oflags |= oflags;
+
+ if (filep->f_oflags & O_APPEND)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org