You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/31 08:39:04 UTC
[GitHub] [incubator-mxnet] PawelGlomski-Intel opened a new pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
PawelGlomski-Intel opened a new pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107
## Description ##
Currently, deconvolution 2D is implemented with oneDNN convolution primitives. Deconvolution forward pass is implemented with convolution backward primitives that do not include bias. This requires you to manually add the bias, which is currently broken (#19768).
This change implements oneDNN deconvolution primitives to deconvolution, fixing (#19768).
As I couldn't reproduce (#20011) for the 2D case, I re-enabled the 2D part of this test.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Implemented oneDNN deconvolution primitives to deconvolution
- [x] Refactored deconvolution code
- [x] Re-enabled deconvolution2D test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-814031570
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-829946330
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#discussion_r606709010
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -469,10 +469,10 @@ def check_convolution_training(stype):
@with_seed()
-@unittest.skip("Flaky test https://github.com/apache/incubator-mxnet/issues/12579")
+# @unittest.skip("Flaky test https://github.com/apache/incubator-mxnet/issues/12579")
Review comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-826649386
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-816518657
@szha can you please merge this PR if you have no further concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-811870594
@mxnet-bot run ci [unix-cpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-833296312
@mxnet-bot run ci [unix-gpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-837671363
Merged. @PawelGlomski-Intel thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-829946292
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-826649347
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-829120564
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-829120589
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-810888267
Hey @PawelGlomski-Intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, unix-gpu, website, unix-cpu, miscellaneous, sanity, edge, clang, windows-gpu, centos-gpu, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-814031491
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-836690987
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-836691090
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#discussion_r609100865
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -469,10 +469,9 @@ def check_convolution_training(stype):
@with_seed()
-@unittest.skip("Flaky test https://github.com/apache/incubator-mxnet/issues/12579")
def test_Deconvolution():
def check_Deconvolution_training(stype):
- for shape in [(3, 3, 10), (3, 3, 10, 10)]:
+ for shape in [(3, 3, 10, 10)]: # testing only 2D for now
Review comment:
"for now" is ok for now ;-), as I assume 3D test will be reintroduced soon. But usually "for now" means nothing to the comment reader and should be replaced with something more specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-811870654
Jenkins CI successfully triggered : [website, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#issuecomment-833296372
Jenkins CI successfully triggered : [centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org