You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/22 23:55:13 UTC

[GitHub] samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value

samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value
URL: https://github.com/apache/incubator-mxnet/pull/12284#issuecomment-415225615
 
 
   @haojin2 linting fixed
   @zhreshold Is catching the exception what we want to do? What should we do after catching the exception? Set the default value? If we dont set something, its just going to error out somewhere further down the line. It seems to me that this is actually a larger and more in-depth problem than it initially appears so ive filed another issue to track that specifically #12286. But fixing that is going require a little more planning. What is the minimum acceptable behavior for this operator to close this issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services