You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "VojtechMucha (via GitHub)" <gi...@apache.org> on 2026/07/22 09:05:29 UTC

[I] PinotPreparedStatement execute doesn't follow jdbc specification [pinot]

VojtechMucha opened a new issue, #19042:
URL: https://github.com/apache/pinot/issues/19042

   `boolean java.sql.PreparedStatement.execute()` method has javadoc: 
   ```
   Returns:
   true if the first result is a ResultSet object; false if the first result is an update count or there is no result
   ```
   
   Pinot implementation in `boolean  org.apache.pinot.client.PinotPreparedStatement.execute()` method returns `false` when the result is `ResultSet` and has no rows. Empty `ResultSet` is a result, it doesn't mean that there is no result. It means that `boolean PinotPreparedStatement.execute()` method does not correctly implement `boolean PreparedStatement.execute()` contract.
   
   We use Jooq framework on top of `pinot-jdbc-client`. Jooq expects correct `PreparedStatement` implementation. With Pinot jdbc driver, Jooq query execution fails if a query result is empty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [I] PinotPreparedStatement execute doesn't follow jdbc specification [pinot]

Posted by "VojtechMucha (via GitHub)" <gi...@apache.org>.
VojtechMucha commented on issue #19042:
URL: https://github.com/apache/pinot/issues/19042#issuecomment-5044134235

   I already prepared a PR: #19043.
   May I please for adding `PEP-Request` label as is described in https://docs.pinot.apache.org/develop-and-contribute/contributing/contribution-guidelines? I probably don't have enough access rights.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [I] PinotPreparedStatement execute doesn't follow jdbc specification [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 closed issue #19042: PinotPreparedStatement execute doesn't follow jdbc specification
URL: https://github.com/apache/pinot/issues/19042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org