You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2011/04/04 16:35:59 UTC
svn commit: r1088639 -
/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java
Author: robbie
Date: Mon Apr 4 14:35:59 2011
New Revision: 1088639
URL: http://svn.apache.org/viewvc?rev=1088639&view=rev
Log:
QPID-3183: some minor improvements to the recently seperated QueueRunner class, based on review feedback from Keith Wall for QPID-3167
Modified:
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java
Modified: qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java?rev=1088639&r1=1088638&r2=1088639&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java (original)
+++ qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java Mon Apr 4 14:35:59 2011
@@ -27,13 +27,18 @@ import org.apache.qpid.server.logging.ac
import org.apache.qpid.server.queue.QueueRunner;
import org.apache.qpid.server.queue.SimpleAMQQueue;
-
+/**
+ * QueueRunners are Runnables used to process a queue when requiring
+ * asynchronous message delivery to subscriptions, which is necessary
+ * when straight-through delivery of a message to a subscription isn't
+ * possible during the enqueue operation.
+ */
public class QueueRunner implements ReadWriteRunnable
{
private static final Logger _logger = Logger.getLogger(QueueRunner.class);
- private String _name;
- private SimpleAMQQueue _queue;
+ private final String _name;
+ private final SimpleAMQQueue _queue;
public QueueRunner(SimpleAMQQueue queue, long count)
{
@@ -53,7 +58,7 @@ public class QueueRunner implements Read
}
catch (AMQException e)
{
- _logger.error(e);
+ _logger.error("Exception during asynchronous delivery by " + _name, e);
}
finally
{
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org