You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/28 15:14:28 UTC

[GitHub] srowen commented on a change in pull request #23910: [SPARK-27007][PYTHON]add rawPrediction to OneVsRest in PySpark

srowen commented on a change in pull request #23910: [SPARK-27007][PYTHON]add rawPrediction to OneVsRest in PySpark
URL: https://github.com/apache/spark/pull/23910#discussion_r261240402
 
 

 ##########
 File path: python/pyspark/sql/dataframe.py
 ##########
 @@ -1980,6 +1980,29 @@ def withColumn(self, colName, col):
         assert isinstance(col, Column), "col should be Column"
         return DataFrame(self._jdf.withColumn(colName, col._jc), self.sql_ctx)
 
+    @ignore_unicode_prefix
+    def withColumns(self, colNames, cols):
 
 Review comment:
   It looks like the Scala impl has this method, but it's not exposed. Instead of adding it here, can you just use two calls to `withColumn` above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org