You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/16 18:58:49 UTC
[GitHub] [flink-statefun] aroch opened a new pull request #99:
[k8s-python-example] build-example.sh improvements
aroch opened a new pull request #99: [k8s-python-example] build-example.sh improvements
URL: https://github.com/apache/flink-statefun/pull/99
- The helm template was printed out instead of being redirected to the resource YAML file.
- In case the SDK distribution was not previously built - instead of failing the build, build the distribution and continue.
- Abort script on failure. Previously, on failure the script would continue to run all steps and finish in an erroneous state. Also this saves 'if' statements to check exit codes after commands execute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] sjwiesman closed pull request #99: [FLINK-17193]
[k8s-python-example] build-example.sh improvements
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #99: [FLINK-17193] [k8s-python-example] build-example.sh improvements
URL: https://github.com/apache/flink-statefun/pull/99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] sjwiesman commented on issue #99: [FLINK-17193]
[k8s-python-example] build-example.sh improvements
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on issue #99: [FLINK-17193] [k8s-python-example] build-example.sh improvements
URL: https://github.com/apache/flink-statefun/pull/99#issuecomment-614851627
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] sjwiesman commented on issue #99:
[k8s-python-example] build-example.sh improvements
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on issue #99: [k8s-python-example] build-example.sh improvements
URL: https://github.com/apache/flink-statefun/pull/99#issuecomment-614849074
Hi @aroch, thank you for fixing this. I will go ahead and merge it.
In the future, could you please open a Jira ticket for this type of change. It helps us keep track on of what is being worked on in the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] sjwiesman commented on issue #99: [FLINK-17193]
[k8s-python-example] build-example.sh improvements
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on issue #99: [FLINK-17193] [k8s-python-example] build-example.sh improvements
URL: https://github.com/apache/flink-statefun/pull/99#issuecomment-614856818
Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] aroch commented on issue #99: [FLINK-17193]
[k8s-python-example] build-example.sh improvements
Posted by GitBox <gi...@apache.org>.
aroch commented on issue #99: [FLINK-17193] [k8s-python-example] build-example.sh improvements
URL: https://github.com/apache/flink-statefun/pull/99#issuecomment-614851758
Thanks @sjwiesman! Just opened an issue and updated accordingly. Was not completely sure about filling the JIRA. Would appreciate if you can take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services