[jira] [Commented] (ARIA-157) CLI unit tests for storing service-templates fail on appveyor

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIA-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004811#comment-16004811 ] 

ASF subversion and git services commented on ARIA-157:
------------------------------------------------------

Commit ca49ae016962a260e0363522482e453b18db024f in incubator-ariatosca's branch refs/heads/ARIA-157-cli-service-template-store-tests-fail-in-windows from [~avia]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=ca49ae0 ]

ARIA-157 Failing CLI service-templates store tests on Windows

Three tests from `aria service-templates store` failed on Windows, but
not on Linux.

The reason for this failures was differing implementation of
os.path.dirname across the platfroms.

Python implements os.path.dirname in the ntpath module. There, somewhere
down the line of calls, (a part of) the argument of dirname is tested
for membership in a string (using `in`). In these three tests, the
argument of dirname is of type MagicMock, and an error is raised since
only a string can be tested for memebership in a string.

The solution was to mock the dirname calls.


> CLI unit tests for storing service-templates fail on appveyor
> -------------------------------------------------------------
>
>                 Key: ARIA-157
>                 URL: https://issues.apache.org/jira/browse/ARIA-157
>             Project: AriaTosca
>          Issue Type: Bug
>            Reporter: Avia Efrat
>            Assignee: Avia Efrat
>
> The failing tests are:
> test_store_no_exception
> test_store_raises_exception_resulting_from_name_uniqueness
> test_store_raises_exception
> They pass on Travis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)