[PATCH] Re: Multiple problems with svn python bindings

[Greg Stein <gs...@lyra.org>]

On Sat, Aug 31, 2002 at 04:20:20PM -0700, Greg Stein wrote:
> On Sat, Aug 31, 2002 at 03:46:19PM -0700, Greg Stein wrote:
> >...
> > > In other words, we just pass the PyObject through to the workaround _foo
> > > function unchanged.
> > 
> > Yup, looks great. And because of the PyObject*, this would be Python
> > specific, so it goes into the swigutil_py.* files.
> 
> Working on this now...

I've attached a patch which compiles and visual inspection seems to do the
right thing. I haven't gone thru the whole mix to try out one of these
functions -- figured on at least getting this patch out for conceptual
review.

It introduces a swig_workarounds.h header to prototype the stubs for the
various per-language stubbing. The old STRINGLIST typemap stuff was ripped
from the .i files and use of these stubs put in place. Finally, the new
stubs were inserted into swigutil_py.c.

Since libsvn_swig_py now depends directly on the client and repos libraries,
I also tweaked build.conf to report this. There was also a small change to
add SVN_ERR_SWIG_PY_EXCEPTION_SET so that we could propagate Python errors
thru svn_error_t.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: [PATCH] Re: Multiple problems with svn python bindings

[Greg Stein <gs...@lyra.org>]

On Mon, Sep 02, 2002 at 02:55:13PM -0500, Jon Trowbridge wrote:
> On Sat, 2002-08-31 at 19:27, Greg Stein wrote:
> > I've attached a patch which compiles and visual inspection seems to do the
> > right thing...
> >
> > It introduces a swig_workarounds.h header to prototype the stubs...
> 
> The swig_workarounds.h file is not included in the patch, presumably
> since that file hadn't been added to the repository.

Grr. I noticed that and regenerated the patch. But I included the wrong file
in my email...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: [PATCH] Re: Multiple problems with svn python bindings

[Jon Trowbridge <tr...@ximian.com>]

On Sat, 2002-08-31 at 19:27, Greg Stein wrote:
> I've attached a patch which compiles and visual inspection seems to do the
> right thing...
>
> It introduces a swig_workarounds.h header to prototype the stubs...

The swig_workarounds.h file is not included in the patch, presumably
since that file hadn't been added to the repository.

-JT



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org