You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/13 23:04:19 UTC
[GitHub] [trafficcontrol] rimashah25 opened a new pull request #4955: Bugifx/cdn 10401
rimashah25 opened a new pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #3400
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Portal
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
**Manual Testing**
1. In Traffic Portal, create a HTTP delivery service
2. Click on `More` and then add Static DNS entry
3. Select a Type and type ttl value as zero (`0`)
4. You can create a static DNS entry with a successful message.
**Automation Testing**
1. Run CIAB
2. Run Traffic_Portal locally (make sure the Traffic_Ops url point to CIAB traffic ops url)
3. Ensure protractor and webdriver-manage are installed.
4. Run webdriver-manager start
5. Run protractor config.js from traffic_control/traffic_portal/test/end-to-end/ folder
6. All 73 specs should pass. `73 specs, 0 failures`
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
- master (e313410)
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests
- [ ] This PR does not include documentation
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4955: Bugifx/cdn 10401
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470689150
##########
File path: traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error': hasError(dsStaticDnsEntryForm.ttl), 'has-feedback': hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2 col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/" required>
Review comment:
@ocket8888 - how about just `pattern` instead of `ng-pattern` since the pattern is static? `min` does not prevent the user from entering -1, for example. basically, i just want to make sure an error message shows up if the user enters a non-whole number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4955: Bugifx/cdn 10401
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470689150
##########
File path: traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error': hasError(dsStaticDnsEntryForm.ttl), 'has-feedback': hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2 col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/" required>
Review comment:
@ocket8888 - how about just `pattern` instead of `ng-pattern` since the pattern is static? `min` does not prevent the user from entering -1, for example. basically, i just want to make sure an alert shows up if the user enters a non-whole number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4955: Bugifx/cdn 10401
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470299293
##########
File path: traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error': hasError(dsStaticDnsEntryForm.ttl), 'has-feedback': hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2 col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/" required>
Review comment:
Does `min="0" step="1"` not work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4955: Allow '0' as a valid value for TTL field in DNS static entry
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470793111
##########
File path: traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error': hasError(dsStaticDnsEntryForm.ttl), 'has-feedback': hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2 col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/" required>
Review comment:
> _"min does not prevent the user from entering -1, for example._"
What do you mean? Like the user can literally type in "-1"? Because you can still do that with `ng-pattern`. Also, without a min, I can use the browser's native controls to enter an invalid value. I can hit the down arrow and get -1. Using `min` and `step` if I put in "-1" I still see the field marked as invalid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4955: Bugifx/cdn 10401
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470316510
##########
File path: traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error': hasError(dsStaticDnsEntryForm.ttl), 'has-feedback': hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2 col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/" required>
Review comment:
Why? `min` and `step` are native `input[type=number]` controls that work within the browser. `ng-pattern` not only adds an event listener, but uses userland scripting to do regular expression matching. It's slower and less idiomatic than the native controls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #4955: Bugifx/cdn 10401
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470308563
##########
File path: traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error': hasError(dsStaticDnsEntryForm.ttl), 'has-feedback': hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2 col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/" required>
Review comment:
It works but ng-pattern seems to be a better approach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #4955: Allow '0' as a valid value for TTL field in DNS static entry
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #4955: Bugifx/cdn 10401
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470308563
##########
File path: traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error': hasError(dsStaticDnsEntryForm.ttl), 'has-feedback': hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2 col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number" class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/" required>
Review comment:
It works but ng-pattern seems to be a better approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org