You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mamta A. Satoor (JIRA)" <ji...@apache.org> on 2007/04/07 03:53:32 UTC

[jira] Created: (DERBY-2530) When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.

When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.
----------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: DERBY-2530
                 URL: https://issues.apache.org/jira/browse/DERBY-2530
             Project: Derby
          Issue Type: New Feature
          Components: SQL
    Affects Versions: 10.3.0.0
            Reporter: Mamta A. Satoor
         Assigned To: Mamta A. Satoor


Persistent user defined character columns get added through CREATE TABLE and ALTER TABLE statements, These 2 statements should set the collation type of character columns' to the same value as the collation type of the schema they belong to. This collation type will get saved in SYSCOLUMNS and will also be saved in the metadata maintained by Store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (DERBY-2530) When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.

Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mamta A. Satoor closed DERBY-2530.
----------------------------------


> When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2530
>                 URL: https://issues.apache.org/jira/browse/DERBY-2530
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2530_create_alter_table_collation_type_v1_diff.txt, DERBY2530_create_alter_table_collation_type_v1_stat.txt
>
>
> Persistent user defined character columns get added through CREATE TABLE and ALTER TABLE statements, These 2 statements should set the collation type of character columns' to the same value as the collation type of the schema they belong to. This collation type will get saved in SYSCOLUMNS and will also be saved in the metadata maintained by Store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (DERBY-2530) When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.

Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487387 ] 

Mamta A. Satoor commented on DERBY-2530:
----------------------------------------

Committed the patch DERBY2530_create_alter_table_collation_type_v1_diff.txt as part of revision 526385.

> When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2530
>                 URL: https://issues.apache.org/jira/browse/DERBY-2530
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2530_create_alter_table_collation_type_v1_diff.txt, DERBY2530_create_alter_table_collation_type_v1_stat.txt
>
>
> Persistent user defined character columns get added through CREATE TABLE and ALTER TABLE statements, These 2 statements should set the collation type of character columns' to the same value as the collation type of the schema they belong to. This collation type will get saved in SYSCOLUMNS and will also be saved in the metadata maintained by Store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (DERBY-2530) When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.

Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mamta A. Satoor resolved DERBY-2530.
------------------------------------

    Resolution: Fixed

> When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2530
>                 URL: https://issues.apache.org/jira/browse/DERBY-2530
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2530_create_alter_table_collation_type_v1_diff.txt, DERBY2530_create_alter_table_collation_type_v1_stat.txt
>
>
> Persistent user defined character columns get added through CREATE TABLE and ALTER TABLE statements, These 2 statements should set the collation type of character columns' to the same value as the collation type of the schema they belong to. This collation type will get saved in SYSCOLUMNS and will also be saved in the metadata maintained by Store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (DERBY-2530) When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.

Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mamta A. Satoor updated DERBY-2530:
-----------------------------------

    Attachment: DERBY2530_create_alter_table_collation_type_v1_stat.txt
                DERBY2530_create_alter_table_collation_type_v1_diff.txt

Attaching the patch DERBY2530_create_alter_table_collation_type_v1_diff.txt which changes alter table and create table code so that the persistent user defined character types will have collation type of their schema.

svn stat -q
M      java\engine\org\apache\derby\impl\sql\compile\AlterTableNode.java
M      java\engine\org\apache\derby\impl\sql\compile\CreateTableNode.java
M      java\engine\org\apache\derby\iapi\sql\dictionary\SchemaDescriptor.java

This patch includes following changes
1)If a character type is getting added by alter table statement then AlterTable node needs to set the collation type of that character column to same value as schema descriptor's collation type. Collation derivation of this column will be set to implicit.
2)For all the character columns that get added by create table statement, CreateTable node should set their collation type to same value as schema descriptor's collation type. Collation derivation of such columns will be set to implicit.
3)Provide a method called getCollationType on SchemaDescriptor so that AlterTable node and CreateTable node can call that method.

The tests have almost finished running. Will commit once everything looks good.

> When character type columns are added by CREATE TABLE and ALTER TABLE, their collation type should be set to the containing schema's collation type.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2530
>                 URL: https://issues.apache.org/jira/browse/DERBY-2530
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2530_create_alter_table_collation_type_v1_diff.txt, DERBY2530_create_alter_table_collation_type_v1_stat.txt
>
>
> Persistent user defined character columns get added through CREATE TABLE and ALTER TABLE statements, These 2 statements should set the collation type of character columns' to the same value as the collation type of the schema they belong to. This collation type will get saved in SYSCOLUMNS and will also be saved in the metadata maintained by Store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.