You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/29 19:51:23 UTC
[kudu-CR] Disable core dumping in integration tests which crash
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3534
to review the following change.
Change subject: Disable core dumping in integration tests which crash
......................................................................
Disable core dumping in integration tests which crash
In TSAN builds, core dumps can take minutes as the virtual address space
is very large. In a few new tests, we injected IO errors and expected
the tserver to crash. In TSAN builds, this crash could take tens of seconds
due to the very large core dumps, and thus result in the test failing.
This is similar to KUDU-942 (and also d3fc252a12f08ba) where we disabled
core dumps for injected crash faults. In these new cases, however, we don't
directly inject a crash, but rather inject an IO error which manifests
itself as a crash.
Change-Id: I2eca1395fa3438861ee1b1ff49978408fed390f4
---
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/util/fault_injection.cc
M src/kudu/util/init.cc
M src/kudu/util/os-util.cc
M src/kudu/util/os-util.h
6 files changed, 46 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/3534/1
--
To view, visit http://gerrit.cloudera.org:8080/3534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2eca1395fa3438861ee1b1ff49978408fed390f4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Disable core dumping in integration tests which crash
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Disable core dumping in integration tests which crash
......................................................................
Patch Set 2: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2102/
--
To view, visit http://gerrit.cloudera.org:8080/3534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2eca1395fa3438861ee1b1ff49978408fed390f4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Disable core dumping in integration tests which crash
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Disable core dumping in integration tests which crash
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2eca1395fa3438861ee1b1ff49978408fed390f4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Disable core dumping in integration tests which crash
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Disable core dumping in integration tests which crash
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2098/
--
To view, visit http://gerrit.cloudera.org:8080/3534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2eca1395fa3438861ee1b1ff49978408fed390f4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Disable core dumping in integration tests which crash
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Disable core dumping in integration tests which crash
......................................................................
Disable core dumping in integration tests which crash
In TSAN builds, core dumps can take minutes as the virtual address space
is very large. In a few new tests, we injected IO errors and expected
the tserver to crash. In TSAN builds, this crash could take tens of seconds
due to the very large core dumps, and thus result in the test failing.
This is similar to KUDU-942 (and also d3fc252a12f08ba) where we disabled
core dumps for injected crash faults. In these new cases, however, we don't
directly inject a crash, but rather inject an IO error which manifests
itself as a crash.
Change-Id: I2eca1395fa3438861ee1b1ff49978408fed390f4
Reviewed-on: http://gerrit.cloudera.org:8080/3534
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/util/fault_injection.cc
M src/kudu/util/init.cc
M src/kudu/util/os-util.cc
M src/kudu/util/os-util.h
6 files changed, 46 insertions(+), 18 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eca1395fa3438861ee1b1ff49978408fed390f4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>