[GitHub] [airflow] mlgruby commented on a change in pull request #11359: Strict type check for Microsoft

[GitBox <gi...@apache.org>]

mlgruby commented on a change in pull request #11359:
URL: https://github.com/apache/airflow/pull/11359#discussion_r501989781



##########
File path: airflow/providers/microsoft/azure/log/wasb_task_handler.py
##########
@@ -17,11 +17,13 @@
 # under the License.
 import os
 import shutil
+from typing import Optional, Tuple, Dict
 
 from azure.common import AzureHttpError
 from cached_property import cached_property
 
 from airflow.configuration import conf
+from airflow.models import TaskInstance

Review comment:
       I am sorry I didn't understand this! 

##########
File path: airflow/providers/microsoft/azure/operators/azure_container_instances.py
##########
@@ -44,7 +44,7 @@
 )
 
 
-DEFAULT_ENVIRONMENT_VARIABLES = {}  # type: Dict[str, str]
+DEFAULT_ENVIRONMENT_VARIABLES = {}  # type: dict
 DEFAULT_SECURED_VARIABLES = []  # type: Sequence[str]
 DEFAULT_VOLUMES = []  # type: Sequence[Volume]

Review comment:
       👍🏼 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org