You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by snuf <gi...@git.apache.org> on 2015/07/10 11:04:58 UTC
[GitHub] cloudstack pull request: Improved message for peeples to actually ...
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/576
Improved message for peeples to actually see what the problem is.
The original message obfuscates what the real problem is, and requires people to dig through the source to figure out that a single VDI is expected. Now it will show that it actually expects 1 and tells you what it found., making it easier for people to do something about it instead of wading through the cloudstack code after not being able to figure it out in the log.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snuf/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/576.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #576
----
commit 89efa9989ad8e5ada2dba24e44f2f1bb0e6ecafa
Author: Funs <fu...@barred.org>
Date: 2015-07-10T09:01:41Z
Improved message for peeples to actually see what the problem is.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Improved message for peeples to actually ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Improved message for peeples to actually ...
Posted by kishankavala <gi...@git.apache.org>.
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/576#issuecomment-120400649
Can we rephrase it as "Expected 1 VDI template but found..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Improved message for peeples to actually ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/576#issuecomment-120455357
LGTM. @snuf see if you can improve the statement as Kishan suggests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Improved message for peeples to actually ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/576#issuecomment-120314141
LGTM, thanks for wading, @snuf
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---