svn commit: r1723882 - /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c

[iv...@apache.org]

Author: ivan
Date: Sat Jan  9 21:50:33 2016
New Revision: 1723882

URL: http://svn.apache.org/viewvc?rev=1723882&view=rev
Log:
Follow-up to r1723865: Relax check in newly added test to copy with known
problem in ra_serf.

* subversion/tests/libsvn_ra/ra-test.c
  (get_dir_test): Do not check DIRENT->SIZE due known problem in ra_serf. This
   test for different bug.

Modified:
    subversion/trunk/subversion/tests/libsvn_ra/ra-test.c

Modified: subversion/trunk/subversion/tests/libsvn_ra/ra-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_ra/ra-test.c?rev=1723882&r1=1723881&r2=1723882&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_ra/ra-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_ra/ra-test.c Sat Jan  9 21:50:33 2016
@@ -620,7 +620,12 @@ get_dir_test(const svn_test_opts_t *opts
   SVN_TEST_INT_ASSERT(apr_hash_count(dirents), 1);
   ent = svn_hash_gets(dirents, "A");
   SVN_TEST_ASSERT(ent);
+
+#if 0
+  /* ra_serf has returns SVN_INVALID_SIZE instead of documented zero for
+   * for directories. */
   SVN_TEST_INT_ASSERT(ent->size, 0);
+#endif
 
   return SVN_NO_ERROR;
 }

Re: svn commit: r1723882 - /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c

[Ivan Zhakov <iv...@apache.org>]

On 27 January 2016 at 15:02, Bert Huijben <be...@qqmail.nl> wrote:
>> -----Original Message-----
>> From: ivan@apache.org [mailto:ivan@apache.org]
>> Sent: zaterdag 9 januari 2016 22:51
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1723882 -
>> /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c
>>
>> Author: ivan
>> Date: Sat Jan  9 21:50:33 2016
>> New Revision: 1723882
>>
>> URL: http://svn.apache.org/viewvc?rev=1723882&view=rev
>> Log:
>> Follow-up to r1723865: Relax check in newly added test to copy with known
>> problem in ra_serf.
>>
>> * subversion/tests/libsvn_ra/ra-test.c
>>   (get_dir_test): Do not check DIRENT->SIZE due known problem in ra_serf.
>> This
>>    test for different bug.
>
> Wasn't it easier to 'just' fix ra_serf here?
>
I've tried, but I didn't have enough time for proper fix that time.

> If I remember correctly serf always retrieves the node kind on retrieved
> nodes, so this shouldn't be hard to fix.
>
I didn't want create dependency on that fact that we always retrieve
node kind. Also DAV properties received in random order, so
resource-type property can be parsed after we parse content-length
property.

-- 
Ivan Zhakov

RE: svn commit: r1723882 - /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: ivan@apache.org [mailto:ivan@apache.org]
> Sent: zaterdag 9 januari 2016 22:51
> To: commits@subversion.apache.org
> Subject: svn commit: r1723882 -
> /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c
> 
> Author: ivan
> Date: Sat Jan  9 21:50:33 2016
> New Revision: 1723882
> 
> URL: http://svn.apache.org/viewvc?rev=1723882&view=rev
> Log:
> Follow-up to r1723865: Relax check in newly added test to copy with known
> problem in ra_serf.
> 
> * subversion/tests/libsvn_ra/ra-test.c
>   (get_dir_test): Do not check DIRENT->SIZE due known problem in ra_serf.
> This
>    test for different bug.

Wasn't it easier to 'just' fix ra_serf here?

If I remember correctly serf always retrieves the node kind on retrieved nodes, so this shouldn't be hard to fix.

	Bert