[jira] [Commented] (CASSANDRA-11625) CFS.CANONICAL_SSTABLES adds compacting sstables without checking if they are still live

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389933#comment-15389933 ] 

Jonathan Ellis commented on CASSANDRA-11625:
--------------------------------------------

Is this still a problem in 3.0.x?  If not I think we should wontfix.

> CFS.CANONICAL_SSTABLES adds compacting sstables without checking if they are still live
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11625
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11625
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>             Fix For: 2.1.x, 2.2.x
>
>
> In 2.1 and 2.2 we blindly add all compacting sstables to the ColumnFamilyStore.CANONICAL_SSTABLES
> This could cause issues as we unmark compacting after removing sstables from the tracker and compaction strategies. For example, when creating scanners for validation with LCS we might get overlap within a level as both the old sstables and the new ones could be in CANONICAL_SSTABLES
> What we need to do is to get the *version* of the sstable from the compacting set as it holds the original sstable without moved starts etc (that is what we do in 3.0+)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)