You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/08/12 19:48:21 UTC
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming package b...
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/816
[BROOKLYN-162] Renaming package brooklyn.location
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn location_package_renamed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #816
----
commit c68ea290439fc32699a4cbe7a94dc15b04082124
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date: 2015-08-12T17:47:41Z
[BROOKLYN-162] Renaming package brooklyn.location
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming package b...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/816#issuecomment-130954333
Merged into #825, conflicts resolved, moved ./api/location to the proper location, tests pass, merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming package b...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/816#issuecomment-130513415
@bostko I saw what you did in this pull request too late. The build failed because you missed a couple of imports in the quickstart archetype, but by now I think I created a bunch of conflicts with the last commits. For the package rename I think we should go straight to using the convention we agreed upon to avoid the split package problem.
I don't know if you want to rework this. If not that's ok, I can take care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming package b...
Posted by CMoH <gi...@git.apache.org>.
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/816#issuecomment-130610089
Tested - I was able to successfully install various sample blueprints. Good for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming package b...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/816#issuecomment-130536456
@hzbarcea I saw it. You can test now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming package b...
Posted by bostko <gi...@git.apache.org>.
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/816
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming package b...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/816#issuecomment-130964528
@bostko , for some reason this wasn't closed automatically, can you please close it manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---