You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Oliver Deakin (JIRA)" <ji...@apache.org> on 2006/03/02 14:55:40 UTC
[jira] Created: (HARMONY-155) Native code tidy up - comments and
casts
Native code tidy up - comments and casts
----------------------------------------
Key: HARMONY-155
URL: http://issues.apache.org/jira/browse/HARMONY-155
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Oliver Deakin
Priority: Minor
Attachments: code.comment.cleanup.diff
Ive been doing a bit of general tidy up of the code in classlib/trunk/native-src, and will be attaching a patch describing all the changes. The work Ive done covers:
- Tidy up of comments, and transfer of useful comments from windows->linux and vice versa where they are missing.
- Transfer of type casts that existed in one platform's code and not the others. This is done with a view to unifying more code in native-src/shared.
- Addition of missing copyrights to .nls files under linux.IA32/zip.
- Removal of unused local variables.
- Some minor source formatting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-155) Native code tidy up - comments and
casts
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-155?page=all ]
Tim Ellison reassigned HARMONY-155:
-----------------------------------
Assign To: Tim Ellison
> Native code tidy up - comments and casts
> ----------------------------------------
>
> Key: HARMONY-155
> URL: http://issues.apache.org/jira/browse/HARMONY-155
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: code.comment.cleanup.diff
>
> Ive been doing a bit of general tidy up of the code in classlib/trunk/native-src, and will be attaching a patch describing all the changes. The work Ive done covers:
> - Tidy up of comments, and transfer of useful comments from windows->linux and vice versa where they are missing.
> - Transfer of type casts that existed in one platform's code and not the others. This is done with a view to unifying more code in native-src/shared.
> - Addition of missing copyrights to .nls files under linux.IA32/zip.
> - Removal of unused local variables.
> - Some minor source formatting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-155) Native code tidy up - comments and
casts
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-155?page=comments#action_12368554 ]
Oliver Deakin commented on HARMONY-155:
---------------------------------------
Looks good, thanks.
> Native code tidy up - comments and casts
> ----------------------------------------
>
> Key: HARMONY-155
> URL: http://issues.apache.org/jira/browse/HARMONY-155
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: code.comment.cleanup.diff
>
> Ive been doing a bit of general tidy up of the code in classlib/trunk/native-src, and will be attaching a patch describing all the changes. The work Ive done covers:
> - Tidy up of comments, and transfer of useful comments from windows->linux and vice versa where they are missing.
> - Transfer of type casts that existed in one platform's code and not the others. This is done with a view to unifying more code in native-src/shared.
> - Addition of missing copyrights to .nls files under linux.IA32/zip.
> - Removal of unused local variables.
> - Some minor source formatting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-155) Native code tidy up - comments and
casts
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-155?page=all ]
Oliver Deakin updated HARMONY-155:
----------------------------------
Attachment: code.comment.cleanup.diff
Attached patch describing code changes
> Native code tidy up - comments and casts
> ----------------------------------------
>
> Key: HARMONY-155
> URL: http://issues.apache.org/jira/browse/HARMONY-155
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Priority: Minor
> Attachments: code.comment.cleanup.diff
>
> Ive been doing a bit of general tidy up of the code in classlib/trunk/native-src, and will be attaching a patch describing all the changes. The work Ive done covers:
> - Tidy up of comments, and transfer of useful comments from windows->linux and vice versa where they are missing.
> - Transfer of type casts that existed in one platform's code and not the others. This is done with a view to unifying more code in native-src/shared.
> - Addition of missing copyrights to .nls files under linux.IA32/zip.
> - Removal of unused local variables.
> - Some minor source formatting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-155) Native code tidy up - comments and
casts
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-155?page=all ]
Tim Ellison resolved HARMONY-155:
---------------------------------
Resolution: Fixed
Thanks for the patch Oliver,
Applied to native-src/ at repo revision 382442.
Please check that the patch was applied as you expected.
> Native code tidy up - comments and casts
> ----------------------------------------
>
> Key: HARMONY-155
> URL: http://issues.apache.org/jira/browse/HARMONY-155
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: code.comment.cleanup.diff
>
> Ive been doing a bit of general tidy up of the code in classlib/trunk/native-src, and will be attaching a patch describing all the changes. The work Ive done covers:
> - Tidy up of comments, and transfer of useful comments from windows->linux and vice versa where they are missing.
> - Transfer of type casts that existed in one platform's code and not the others. This is done with a view to unifying more code in native-src/shared.
> - Addition of missing copyrights to .nls files under linux.IA32/zip.
> - Removal of unused local variables.
> - Some minor source formatting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-155) Native code tidy up - comments and
casts
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-155?page=all ]
Tim Ellison closed HARMONY-155:
-------------------------------
Verified by Oliver
> Native code tidy up - comments and casts
> ----------------------------------------
>
> Key: HARMONY-155
> URL: http://issues.apache.org/jira/browse/HARMONY-155
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: code.comment.cleanup.diff
>
> Ive been doing a bit of general tidy up of the code in classlib/trunk/native-src, and will be attaching a patch describing all the changes. The work Ive done covers:
> - Tidy up of comments, and transfer of useful comments from windows->linux and vice versa where they are missing.
> - Transfer of type casts that existed in one platform's code and not the others. This is done with a view to unifying more code in native-src/shared.
> - Addition of missing copyrights to .nls files under linux.IA32/zip.
> - Removal of unused local variables.
> - Some minor source formatting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira