You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/01/08 17:38:01 UTC

Review Request 29709: Validation missing on Service config related to JVM.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29709/
-----------------------------------------------------------

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-9047
    https://issues.apache.org/jira/browse/AMBARI-9047


Repository: ambari


Description
-------

Even if enter a value of 2049 for 'Namenode java heap size' it fails, because JVM accepts only values which are powers of 2.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 2d7b0b2 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 44c04a2 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 3a8d79b 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 2b8ce44 

Diff: https://reviews.apache.org/r/29709/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [3.414s]
[INFO] Ambari Server ..................................... SUCCESS [33.530s]
[INFO] Ambari Agent ...................................... SUCCESS [16.272s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.192s
[INFO] Finished at: Thu Jan 08 19:36:20 FET 2015
[INFO] Final Memory: 46M/384M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 29709: Validation missing on Service config related to JVM.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29709/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 4:50 p.m.)


Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-9047
    https://issues.apache.org/jira/browse/AMBARI-9047


Repository: ambari


Description
-------

Even if enter a value of 2049 for 'Namenode java heap size' it fails, because JVM accepts only values which are even


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 2d7b0b2 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 44c04a2 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 3a8d79b 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 2b8ce44 

Diff: https://reviews.apache.org/r/29709/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [3.414s]
[INFO] Ambari Server ..................................... SUCCESS [33.530s]
[INFO] Ambari Agent ...................................... SUCCESS [16.272s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.192s
[INFO] Finished at: Thu Jan 08 19:36:20 FET 2015
[INFO] Final Memory: 46M/384M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 29709: Validation missing on Service config related to JVM.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29709/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 4:49 p.m.)


Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-9047
    https://issues.apache.org/jira/browse/AMBARI-9047


Repository: ambari


Description (updated)
-------

Even if enter a value of 2049 for 'Namenode java heap size' it fails, because JVM accepts only values which are even


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 2d7b0b2 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 44c04a2 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 3a8d79b 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 2b8ce44 

Diff: https://reviews.apache.org/r/29709/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [3.414s]
[INFO] Ambari Server ..................................... SUCCESS [33.530s]
[INFO] Ambari Agent ...................................... SUCCESS [16.272s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.192s
[INFO] Finished at: Thu Jan 08 19:36:20 FET 2015
[INFO] Final Memory: 46M/384M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko