You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/14 07:56:51 UTC
[GitHub] [bookkeeper] lhotari opened a new pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
lhotari opened a new pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107
Descriptions of the changes in this PR:
### Motivation
IntelliJ shows compilation errors for BookKeeper code that references Protobuf generated classes after importing the BookKeeper project to IntelliJ IDEA.
### Changes
- Set generated code directory for protobuf gradle plugin to `${projectDir}/src/generated` so that code gets generated to a path that isn't ignored in IntelliJ
- Apply the 'idea' plugin before 'com.google.protobuf' plugin since the protobuf plugin will only setup source code paths for the generated code if idea plugin is present
- [Use the `org.jetbrains.gradle.plugin.idea-ext` plugin](https://github.com/JetBrains/gradle-idea-ext-plugin/wiki#gradle-tasks-triggers-settings) to run the `generateProto` tasks automatically after importing / refreshing the Gradle project in IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1068164325
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1066565457
> If I run this command I get the warning below: `./gradlew build -x test`
@eolivelli Does this warning also appear without the changes in this PR? (I tried checking, but `./gradlew build -x test` fails with `Cannot perform signing task ':bookkeeper-dist:signDistTar' because it has no configured signatory`, I guess there's something else I'd have to do.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari edited a comment on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
lhotari edited a comment on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1066824623
> I am still seeing other warnings, not a blocker for this patch
>
> ```
> Execution optimizations have been disabled for task ':bookkeeper-dist-server:distZip' to ensure correctness due to the following reasons:
> - Gradle detected a problem with the following location: '/Users/enrico.olivelli/dev/bookkeeper/bookkeeper-common-allocator/build/libs/bookkeeper-common-allocator.jar'. Reason: Task ':bookkeeper-dist-server:distZip' uses this output of task ':bookkeeper-common-allocator:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> - Gradle detected a problem with the following location: '/Users/enrico.olivelli/dev/bookkeeper/bookkeeper-common/build/libs/bookkeeper-common.jar'. Reason: Task ':bookkeeper-dist-server:distZip' uses this output of task ':bookkeeper-common:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> - Gradle detected a problem with the following location: '/Users/enrico.olivelli/dev/bookkeeper/bookkeeper-http/vertx-http-server/build/libs/vertx-http-server.jar'. Reason: Task ':bookkeeper-dist-server:distZip' uses this output of task ':bookkeeper-http:vertx-http-server:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> ```
Yes this is an existing problem which isn't caused by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1066746716
I am adding "-x signDistTar"
btw with the latest commit I don't see the warning anymore, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1068055432
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1066537617
If I run this command I get the warning below:
`./gradlew build -x test`
```
> Task :bookkeeper-dist:distZip
Execution optimizations have been disabled for task ':bookkeeper-dist:distZip' to ensure correctness due to the following reasons:
- Gradle detected a problem with the following location: '/Users/enrico.olivelli/dev/bookkeeper'. Reason: Task ':bookkeeper-dist:distZip' uses this output of task ':bookkeeper-proto:generateProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1066571457
@eolivelli I pushed 222e6bb as an attempt to fix the warning. Can you check if it goes away? (unfortunately I have the signing error message so I couldn't test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1066824623
> LGTM
>
> I am still seeing other warnings, not a blocker for this patch
>
> ```
> Execution optimizations have been disabled for task ':bookkeeper-dist-server:distZip' to ensure correctness due to the following reasons:
> - Gradle detected a problem with the following location: '/Users/enrico.olivelli/dev/bookkeeper/bookkeeper-common-allocator/build/libs/bookkeeper-common-allocator.jar'. Reason: Task ':bookkeeper-dist-server:distZip' uses this output of task ':bookkeeper-common-allocator:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> - Gradle detected a problem with the following location: '/Users/enrico.olivelli/dev/bookkeeper/bookkeeper-common/build/libs/bookkeeper-common.jar'. Reason: Task ':bookkeeper-dist-server:distZip' uses this output of task ':bookkeeper-common:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> - Gradle detected a problem with the following location: '/Users/enrico.olivelli/dev/bookkeeper/bookkeeper-http/vertx-http-server/build/libs/vertx-http-server.jar'. Reason: Task ':bookkeeper-dist-server:distZip' uses this output of task ':bookkeeper-http:vertx-http-server:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> ```
Yes this is an existing problem which isn't caused by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on pull request #3107: Run protobuf code generation automatically in IntelliJ and fix config
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #3107:
URL: https://github.com/apache/bookkeeper/pull/3107#issuecomment-1067597235
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org