[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r284724257
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputGateDeploymentDescriptor.java
 ##########
 @@ -57,23 +61,33 @@
 	private final int consumedSubpartitionIndex;
 
 	/** An input channel for each consumed subpartition. */
-	private final InputChannelDeploymentDescriptor[] inputChannels;
-
-	public InputGateDeploymentDescriptor(
-			IntermediateDataSetID consumedResultId,
-			ResultPartitionType consumedPartitionType,
-			int consumedSubpartitionIndex,
-			InputChannelDeploymentDescriptor[] inputChannels) {
+	@Nonnull
+	private final ShuffleDeploymentDescriptor[] inputChannels;
 
-		this.consumedResultId = checkNotNull(consumedResultId);
-		this.consumedPartitionType = checkNotNull(consumedPartitionType);
+	/**
+	 * {@link ResourceID} of partition consumer.
+	 *
+	 * <p>It can be used e.g. to compare with partition producer {@link ResourceID} in
+	 * {@link org.apache.flink.runtime.shuffle.ProducerShuffleDescriptor} to determine producer/consumer co-location.
+	 */
+	@Nonnull
+	private final ResourceID consumerResourceId;
 
-		checkArgument(consumedSubpartitionIndex >= 0);
+	public InputGateDeploymentDescriptor(
+		@Nonnull IntermediateDataSetID consumedResultId,
+		@Nonnull ResultPartitionType consumedPartitionType,
+		@Nonnegative int consumedSubpartitionIndex,
+		@Nonnull ShuffleDeploymentDescriptor[] inputChannels,
+		@Nonnull ResourceID consumerResourceId) {
 
 Review comment:
   Flink's code base uses double indentation to distinguish the parameters from the function body.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services