You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/09 01:56:01 UTC

Review Request 70171: Added `Try` constructors from `_Some`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70171/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Repository: mesos


Description
-------

This is necessary in cases such as constructing
`Result<T>` from `T`:
```
  Result(const T& _t)
    : data(Some(_t)) {}
```
to avoid unnecessary implicit conversions and copies.


Diffs
-----

  3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444 


Diff: https://reviews.apache.org/r/70171/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu

Re: Review Request 70171: Added `Try` constructors from `_Some`.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70171/#review213608
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On March 9, 2019, 1:56 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70171/
> -----------------------------------------------------------
> 
> (Updated March 9, 2019, 1:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is necessary in cases such as constructing
> `Result<T>` from `T`:
> ```
>   Result(const T& _t)
>     : data(Some(_t)) {}
> ```
> to avoid unnecessary implicit conversions and copies.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444 
> 
> 
> Diff: https://reviews.apache.org/r/70171/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>