You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/29 04:22:50 UTC
[GitHub] [airflow] oxymor0n opened a new pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
oxymor0n opened a new pull request #8625:
URL: https://github.com/apache/airflow/pull/8625
`PostgresHook`'s parent class, `DbApiHook`, implements upsert in its `insert_rows()` method with the `replace=True` flag. However, the underlying generated SQL is specific to MySQL's "REPLACE INTO" syntax and is not applicable to Postgres.
I'd like to override this method in PostgresHook to implement the "INSERT ... ON CONFLICT DO UPDATE" syntax (new since Postgres 9.5)
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8625:
URL: https://github.com/apache/airflow/pull/8625#issuecomment-621810841
Marking it for 1.10.11 for now, when we start cherry-picking will double check if it is fine for 1.10.11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tooptoop4 commented on pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on pull request #8625:
URL: https://github.com/apache/airflow/pull/8625#issuecomment-621518087
nice commit titles by the way!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #8625:
URL: https://github.com/apache/airflow/pull/8625#issuecomment-620981202
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #8625:
URL: https://github.com/apache/airflow/pull/8625#issuecomment-621715353
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sahilthapar commented on pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
Posted by GitBox <gi...@apache.org>.
sahilthapar commented on pull request #8625:
URL: https://github.com/apache/airflow/pull/8625#issuecomment-686296002
The upsert functionality doesn't support "Overriding system value" for identity columns, any planned support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8625:
URL: https://github.com/apache/airflow/pull/8625#issuecomment-621715491
@kaxil Think we could pull this in to 1.10.11 easily or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mrkcohen commented on pull request #8625: [AIRFLOW-4734] Upsert functionality for PostgresHook.insert_rows()
Posted by GitBox <gi...@apache.org>.
mrkcohen commented on pull request #8625:
URL: https://github.com/apache/airflow/pull/8625#issuecomment-663202859
This is exactly what I was just about to implement @oxymor0n ! Thank you for doing this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org