You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "rdtr (GitHub)" <gi...@apache.org> on 2019/12/16 19:17:30 UTC
[GitHub] [tinkerpop] rdtr opened pull request #1235: TINKERPOP-2320
allow to pass custom XmlInputFactory when instantiating GraphMLReader
This pull request is a revised one from https://github.com/apache/tinkerpop/pull/1230.
Some provider wants to use XMLInputFactory with more secure configurations. This change makes it possible to pass XMLInputFactory when instantiating GraphMLReader.
I don't add any tests right now, I want to first confirm if this direction is OK. If yes, please suggest any tests that I need to add. Thanks !
[ Full content available at: https://github.com/apache/tinkerpop/pull/1235 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1235:
TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating
GraphMLReader
Posted by "spmallette (GitHub)" <gi...@apache.org>.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1235 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] rdtr commented on pull request #1235:
TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating
GraphMLReader
Posted by "rdtr (GitHub)" <gi...@apache.org>.
Sorry I was lazy... this should have been
```
if (this.inputFactory == null)
```
I updated the PR. Thanks!
[ Full content available at: https://github.com/apache/tinkerpop/pull/1235 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1235:
TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating
GraphMLReader
Posted by "spmallette (GitHub)" <gi...@apache.org>.
No need to add the JIRA number - those get added separately on release.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1235 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1235:
TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating
GraphMLReader
Posted by "spmallette (GitHub)" <gi...@apache.org>.
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1235 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org