You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/10/13 17:11:56 UTC
[PR] fix(clickhouse): bump Altinity.Cloud's documented clickhouse-connect floor [superset]
rusackas opened a new pull request, #45249:
URL: https://github.com/apache/superset/pull/45249
### SUMMARY
Every ClickHouse compatible-database entry documents `clickhouse-connect>=1.8.0,<2.0`, matching `pyproject.toml`'s `clickhouse` extra, except `Altinity.Cloud`, which was still pinned to the old `>=0.13.0` floor. That floor connects but fails SQLAlchemy 2.0 schema discovery.
Caught by bito's review on #44901, which bumped every other ClickHouse entry's documented driver floor but missed this one. This closes the gap; no conflict with that PR either way, it doesn't touch this line.
### TESTING INSTRUCTIONS
```
pytest tests/unit_tests/db_engine_specs/test_clickhouse.py
```
`pre-commit` clean on both changed files.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(clickhouse): bump Altinity.Cloud's documented clickhouse-connect floor [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45249:
URL: https://github.com/apache/superset/pull/45249#issuecomment-6152621845
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45249?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.82%. Comparing base ([`8ace079`](https://app.codecov.io/gh/apache/superset/commit/8ace079d8de783a63810193f55709fc13a972b2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8a31c81`](https://app.codecov.io/gh/apache/superset/commit/8a31c818a816d8f14c2e25070acc6d0f2a454b59?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (8ace079) and HEAD (8a31c81). Click for more details.
>
> <details><summary>HEAD has 4 uploads less than BASE</summary>
>
>| Flag | BASE (8ace079) | HEAD (8a31c81) |
>|------|------|------|
>|python|7|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45249 +/- ##
===========================================
- Coverage 83.23% 64.82% -18.42%
===========================================
Files 3037 3037
Lines 197883 197883
Branches 46118 46118
===========================================
- Hits 164709 128268 -36441
- Misses 29948 66712 +36764
+ Partials 3226 2903 -323
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.02% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.79% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.96% <ø> (-33.90%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.85% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/45249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45249?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(clickhouse): bump Altinity.Cloud's documented clickhouse-connect floor [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45249:
URL: https://github.com/apache/superset/pull/45249#issuecomment-6151053752
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 8a31c818a816d8f14c2e25070acc6d0f2a454b59 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ace665db9c24b6218ff89c1 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45249--superset-docs-preview.netlify.app](https://deploy-preview-45249--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5CaMk-0HP0FVpyVTMIon-nrc5zAspxyMVWAA60FkF3JodPT16wn2L12mZ8oUClcpMpttmlii0bWzysa6mfaHQCjEZLXEYtRj47NwskcP3Aw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-45249--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(clickhouse): bump Altinity.Cloud's documented clickhouse-connect floor [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45249:
URL: https://github.com/apache/superset/pull/45249#issuecomment-6151144803
## CodeAnt PR Risk: Low Risk
- The PR appears safe to merge; it updates the ClickHouse Connect version range consistently in both metadata files.
**Assessed commit:** `8a31c818a816`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(clickhouse): bump Altinity.Cloud's documented clickhouse-connect floor [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #45249:
URL: https://github.com/apache/superset/pull/45249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org